-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphView: fix width of the vertical labels #71
Conversation
The same width value was used for both horizontal and vertical labels, making the vertical labels too wide when the horizontal labels are wider than the real width of the vertical labels. This fix makes use of the real width of the vertical labels.
I also noticed this problem and wanted to report it today. Your workaround works great ! I think the author should test it and approve. |
GraphView: fix width of the vertical labels
many thanks |
The issue you are describing seems to occur when the viewport is not set. Thanks for the merge btw. |
you are right. For this example I tried to put: graphView.setViewPort(data[0].getX(), (data[data.length-1].getX()-data[0].getX())); And then it works. (This code basically means, set viewport to values, like they would be without any viewport set --> from start to whole data range). However, when I stop pinching (to zoom), the viewport moves a bit to the right or left. When dealing with a large set of values, that could be disturbing. I will probably open a new issue for that and post a video. |
The video of the latest jumpy scrolling problem is here: https://www.youtube.com/watch?v=OfdQdeiEAU0 Should I open a new Issue ? |
@Lauszus |
The same width value was used for both horizontal and vertical labels,
making the vertical labels too wide when the horizontal labels are
wider than the real width of the vertical labels. This fix makes use
of the real width of the vertical labels.
Before and after the fix:
.