Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 6, 2018

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 5.0.2 of mocha was just published.

Dependency mocha
Current Version 3.5.3
Type devDependency

The version 5.0.2 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of mocha.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v5.0.2

5.0.2 / 2018-03-05

This release fixes a class of tests which report as false positives. Certain tests will now break, though they would have previously been reported as passing. Details below. Sorry for the inconvenience!

🐛 Fixes

  • #3226: Do not swallow errors that are thrown asynchronously from passing tests (@boneskull). Example:

    it('should actually fail, sorry!', function (done) {
      // passing assertion
      assert(true === true);
    

    // test complete & is marked as passing
    done();

    // ...but something evil lurks within
    setTimeout(() => {
    throw new Error('chaos!');
    }, 100);
    });

    Previously to this version, Mocha would have silently swallowed the chaos! exception, and you wouldn't know. Well, now you know. Mocha cannot recover from this gracefully, so it will exit with a nonzero code.

    Maintainers of external reporters: If a test of this class is encountered, the Runner instance will emit the end event twice; you may need to change your reporter to use runner.once('end') intead of runner.on('end').

  • #3093: Fix stack trace reformatting problem (@outsideris)

:nut_and_bolt Other

Commits

The new version differs by 517 commits.

  • f2ee53c Release v5.0.2
  • ff1bd9e update package-lock.json
  • 6a796cb prepare CHANGELOG for v5.0.2 [ci skip]
  • 0542c40 update README.md; closes #3191 [ci skip]
  • afcd08f add MAINTAINERS.md to .fossaignore [ci skip]
  • 3792bef add opencollective header image to assets/
  • 5078fc5 persist paths in stack trace which have cwd as infix
  • 2c720a3 do not eat exceptions thrown asynchronously from passed tests; closes #3226
  • 3537061 Update to correctly licensed browser-stdout version
  • ec8901a remove unused functionality in utils module
  • f71f347 rename wallaby.js -> .wallaby.js
  • c4ef568 fix PR url
  • 73d55ac fix typos in changelog [ci skip]
  • 09ce746 Release v5.0.1
  • 70027b6 update changelog for v5.0.1 [ci skip]

There are 250 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@coveralls
Copy link

coveralls commented Mar 6, 2018

Coverage Status

Coverage remained the same at 94.595% when pulling 8d5d5ad on greenkeeper/mocha-5.0.2 into 57ae084 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.595% when pulling 8d5d5ad on greenkeeper/mocha-5.0.2 into 57ae084 on master.

@coveralls
Copy link

coveralls commented Mar 6, 2018

Coverage Status

Coverage remained the same at 94.595% when pulling 8d5d5ad on greenkeeper/mocha-5.0.2 into 57ae084 on master.

greenkeeper bot added a commit that referenced this pull request Mar 7, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 7, 2018

Version 5.0.3 just got published.

Update to this version instead 🚀

Release Notes v5.0.3

5.0.3 / 2018-03-06

This patch features a fix to address a potential "low severity" ReDoS vulnerability in the diff package (a dependency of Mocha).

🔒 Security Fixes

🔩 Other

Commits

The new version differs by 6 commits.

  • da6e5c9 Release v5.0.3
  • 70d9262 update CHANGELOG.md for v5.0.3 [ci skip]
  • aaaa5ab fix: ReDoS vuln in mocha@5.0.2 › diff@3.3.1 (#3266)
  • 8df5727 Tidies up code after review
  • 660bccc adds unit tests covering Base.generateDiff
  • bdcb3c3 exposes generateDiff function from base reporter

See the full diff

greenkeeper bot added a commit that referenced this pull request Mar 7, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 7, 2018

Version 5.0.4 just got published.

Update to this version instead 🚀

Release Notes v5.0.4

5.0.4 / 2018-03-07

🐛 Fixes

  • #3265: Fixes regression in "watch" functionality introduced in v5.0.2 (@outsideris)
Commits

The new version differs by 3 commits.

  • 851ad29 Release v5.0.4
  • 868830a update CHANGELOG.md for v5.0.4 [ci skip]
  • eb09421 restore removed methods which still used

See the full diff

@greenkeeper greenkeeper bot deleted the greenkeeper/mocha-5.0.2 branch March 12, 2018 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant