feat(taskList): refocus last task after notes were edited

Author: johannesjo

app-src/scripts/dialogs/help/help-task-list.html

@@ -48,11 +48,11 @@ <h3 class="md-title">An interactive example task</h3>
       <md-button class="md-icon-button play-btn"
                  aria-label="mark as current"
                  tabindex="2"
-                 ng-click="$ctrl.isCurrent= !$ctrl.isCurrent">
+                 ng-click="vm.isCurrent= !vm.isCurrent">
         <md-tooltip>
           Starts time tracking for the task and marks it as current task. Will only appear on the work view.
         </md-tooltip>
-        <ng-md-icon icon="{{$ctrl.isCurrent? 'pause_circle_filled':'play_circle_fill'}}"
+        <ng-md-icon icon="{{vm.isCurrent? 'pause_circle_filled':'play_circle_fill'}}"
                     aria-label="start task"></ng-md-icon>
       </md-button>
 
@@ -81,8 +81,7 @@ <h3 class="md-title">An interactive example task</h3>
         <md-button class="md-icon-button"
                    tabindex="2"
                    ng-disabled="vm.exampleTask.subTasks.length>0"
-                   aria-label="time estimation"
-                   ng-click="$ctrl.estimateTime(task)">
+                   aria-label="time estimation">
           <md-tooltip>
             Opens a dialog for you to specify time spend and time estimated for the task
           </md-tooltip>
@@ -135,7 +134,6 @@ <h3 class="md-title">An interactive example task</h3>
           </md-tooltip>
           <md-checkbox ng-model="vm.exampleTask.isDone"
                        tabindex="2"
-                       ng-change="$ctrl.onTaskDoneChanged(task)"
                        aria-label="un-/mark as done">
           </md-checkbox>
         </span>
@@ -181,8 +179,7 @@ <h3 class="md-title">An interactive example task</h3>
           <md-tooltip>
             Notes section. Click to edit.
           </md-tooltip>
-          <inline-markdown ng-model="vm.exampleTask.notes"
-                           on-changed="$ctrl.onTaskNotesChanged(task)"></inline-markdown>
+          <inline-markdown ng-model="vm.exampleTask.notes"></inline-markdown>
         </div>
       </section>
 

app-src/scripts/inline-markdown/inline-markdown-d.js

@@ -22,7 +22,7 @@
       restrict: 'E',
       scope: {
         ngModel: '=',
-        onChanged: '&'
+        onEditFinished: '&'
       }
     };
   }
@@ -88,15 +88,17 @@
       vm.showEdit = false;
       makeLinksWorkForElectron();
       vm.resizeToFit();
+      const isChanged = (ngModelCopy !== vm.ngModel);
 
-      if (ngModelCopy !== vm.ngModel) {
+      if (isChanged) {
         vm.ngModel = ngModelCopy;
+      }
 
-        if (angular.isFunction(vm.onChanged)) {
-          vm.onChanged({
-            newVal: ngModelCopy
-          });
-        }
+      if (angular.isFunction(vm.onEditFinished)) {
+        vm.onEditFinished({
+          newVal: vm.ngModel,
+          isChanged: isChanged
+        });
       }
     };
 

app-src/scripts/task-list/task-list-d.html

@@ -155,7 +155,7 @@
              ng-bind="task.originalId ? 'Description': 'Notes'"></div>
         <div md-whiteframe="4">
           <inline-markdown ng-model="task.notes"
-                           on-changed="$ctrl.onTaskNotesChanged(newVal, task)"></inline-markdown>
+                           on-edit-finished="$ctrl.onTaskNotesEditFinished(newVal, isChanged, task)"></inline-markdown>
         </div>
       </section>
 

app-src/scripts/task-list/task-list-d.js

@@ -183,12 +183,14 @@
       }
     }
 
-    onTaskNotesChanged(newNoteVal, task) {
-      if (task.originalKey) {
+    onTaskNotesEditFinished(newNoteVal, isChanged, task) {
+      if (task.originalKey && isChanged) {
         // for some reason, this isn't updated for the task, so we do it here once more
         task.notes = newNoteVal;
         this.Jira.updateIssueDescription(task);
       }
+
+      this.focusLastFocusedTaskEl();
     }
 
     onTaskDoneChanged(task) {