fix: unable to create or delete projects #37

Author: johannesjo

app-src/scripts/main/global-services/projects-s.js

@@ -68,14 +68,36 @@
     };
 
     this.createNewFromCurrent = (projectTitle) => {
-      if ($rootScope.r.projects.length > 0) {
+      const projects = this.getListWithLsData();
+      if (projects) {
         SimpleToast('ERROR', 'ERROR: There is already a project');
         return;
       }
 
       this.createNew(projectTitle, $rootScope.r);
     };
 
+    this.remove = (projectToRemove) => {
+      const projects = this.getListWithLsData();
+      const indexToDelete = projects.findIndex((lProj) => {
+        return lProj.id === projectToRemove.id;
+      });
+
+      projects.splice(indexToDelete, 1);
+      AppStorage.saveProjects(projects);
+
+      // project has been deleted so show message already here
+      // even if something below goes wrong
+      SimpleToast('SUCCESS', projectToRemove.title + ' deleted!');
+
+      // also delete from $rootScope
+      const indexToDeleteViewModel = $rootScope.r.projects.findIndex((lProj) => {
+        return lProj.id === projectToRemove.id;
+      });
+      $rootScope.r.projects.splice(indexToDeleteViewModel, 1);
+
+    };
+
     this.createNew = (projectTitle, data) => {
       if (projectTitle && angular.isObject(data)) {
         // save new project
@@ -89,7 +111,7 @@
         $rootScope.r.projects.push(newProject);
 
         // update ls
-        const projects = this.getListWithLsData();
+        const projects = this.getListWithLsData() || [];
         projects.push(newProject);
         AppStorage.saveProjects(projects);
 
@@ -158,6 +180,9 @@
 
         // re-init all global models
         InitGlobalModels();
+
+        // Show success message
+        SimpleToast('SUCCESS', `Switched to project "${newCurrentProject.title}"`);
       }
     };
   }

app-src/scripts/settings/project-settings/project-settings-d.js

@@ -42,7 +42,7 @@
       Dialogs('CREATE_PROJECT');
     };
 
-    vm.deleteProject = (project, $index) => {
+    vm.deleteProject = (project) => {
       if (project.id === $rootScope.r.currentProject.id) {
         SimpleToast('ERROR', 'Cannot delete ' + project.title + ' as it is the current project!');
       } else {
@@ -54,8 +54,7 @@
           .cancel('Better not');
 
         $mdDialog.show(confirm).then(function () {
-          vm.allProjects.splice($index, 1);
-          SimpleToast('SUCCESS', project.title + ' deleted!');
+          Projects.remove(project);
         });
       }
     };