add a line number argument to open_editor #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows opening the editor from the diff or stage view, at the actual line number. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
|
Thanks, I made a couple of improvements so it also works for blob and untracked files. |
|
Great! I'm glad you like it! Thanks for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut Jonas!
This is the v2 of #118. I figured out that vi accepts (as many other editors do) the +num argument before the filename. So I just add it in the editor_argv, if needed.
So far, I tested vi, vim, emacs, nano, gedit, geany and they are known to work fine.
The option is applied on the diff and stage view.
Cheers,
Vivien