Fix 404 - when url entered directly into the browser #92
Conversation
Pull Request Test Coverage Report for Build 497
💛 - Coveralls |
|
|
||
| // Forwards all routes to FrontEnd except: '/', '/index.html', '/api', '/api/**' | ||
| // Required because of 'mode: history' usage in frontend routing, see README for further details | ||
| @RequestMapping(value = "{_:^(?!index\\.html|api).*$}") |
There was a problem hiding this comment.
The forward in this rule did not work for two reasons
- it was placed int he wrong
RequestMappingcontext as it would look for the pattern only after/api - it was placed in a
RestControllerinstead of aControllerthat does not support returning aforwad:/
Although the filter probably does work the easier solution would be to just fix 1) & 2)
There was a problem hiding this comment.
Thanks for the info, I didn't knew about it! I'll see if it works and I'll update the PR in the mean time
There was a problem hiding this comment.
@hemeroc I've tried to follow your idea, you were right about the using Controller instead of RestController but unfortunately, this solution only works on one level URLs like this /login but not for this /auth/login or any URL that has many deep level path as you can see the tests here:
Do you have any idea on how to match URLs with multiple levels?
There was a problem hiding this comment.
I've found a way to accomplish using @Controller instead of Filter I'll update as soon as possible
There was a problem hiding this comment.
I've found a way to accomplish using
@Controllerinstead ofFilterI'll update as soon as possible
when you will update :)
There was a problem hiding this comment.
@isneezy great contribution 👍 Sorry, didn't find the time earlier.
|
|
||
| // Forwards all routes to FrontEnd except: '/', '/index.html', '/api', '/api/**' | ||
| // Required because of 'mode: history' usage in frontend routing, see README for further details | ||
| @RequestMapping(value = "{_:^(?!index\\.html|api).*$}") |
There was a problem hiding this comment.
@isneezy great contribution 👍 Sorry, didn't find the time earlier.
…ixed SpaRedirectTest not Found message String.
…tSpa:33->assertSpaResponse:58 1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "<script src=/static/js/chunk-vendors"
Actual: <!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" href="/favicon.ico"><title>frontend</title><link href="/static/css/app.6dd46426.css" rel="preload" as="style"><link href="/static/css/chunk-vendors.2f24a82e.css" rel="preload" as="style"><link href="/static/js/app.5c8c692c.js" rel="preload" as="script"><link href="/static/js/chunk-vendors.f6c6f821.js" rel="preload" as="script"><link href="/static/css/chunk-vendors.2f24a82e.css" rel="stylesheet"><link href="/static/css/app.6dd46426.css" rel="stylesheet"></head><body><noscript><strong>We're sorry but frontend doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id="app"></div><script src="/static/js/chunk-vendors.f6c6f821.js"></script><script src="/static/js/app.5c8c692c.js"></script></body></html>`
I've fixed the White Label error with a simple filter by reusing the existing REGEX
The only catch up with this approach is that if you plan to have other URLs other than
/apiex:/oauthetc you'll have to include them in the REGEX expressionFixes #41