Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate this into react-navigation? #2

Closed
thomaswang opened this issue Oct 1, 2019 · 2 comments
Closed

Integrate this into react-navigation? #2

thomaswang opened this issue Oct 1, 2019 · 2 comments

Comments

@thomaswang
Copy link

@thomaswang thomaswang commented Oct 1, 2019

Great component! This is the most highly requested features of the community for @react-navigation. Starting this issue to see if integration is possible.

iOS large title FR from Canny: https://react-navigation.canny.io/feature-requests/p/ios-11-large-header-and-growshrink-on-scroll
React Navigation: https://github.com/react-navigation/react-navigation

@thomaswang

This comment has been minimized.

Copy link
Author

@thomaswang thomaswang commented Oct 1, 2019

React Navigation Contributing Guidelines: https://reactnavigation.org/docs/en/contributing.html

@jonsamp

This comment has been minimized.

Copy link
Owner

@jonsamp jonsamp commented Oct 6, 2019

@thomaswangio thanks for the issue and for nominating this package.

Closing this ticket bc your PR was merged. Noting some links for posterity:

Twitter discussion: https://twitter.com/thomaswangio/status/1179164439884386304?s=20
PR: https://github.com/react-navigation/react-navigation.github.io/pull/533/files
Link in react-navigation docs: https://reactnavigation.org/docs/en/next/community-libraries-and-navigators.html

@jonsamp jonsamp closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.