Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve travis tests: test other php versions (5.6, 7 and hhvm); run code style tests only on one php version #292

Merged
merged 4 commits into from
Mar 23, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

Check code difference

I'm not sure is anything else is needed.

the patchtester travis.yml is a little different reggarding CS
See https://github.com/joomla-extensions/patchtester/blob/master/.travis.yml

@andrepereiradasilva
Copy link
Contributor Author

it seems something more is needed because travis did not run on this PR

@mbabker
Copy link
Contributor

mbabker commented Mar 21, 2016

Since you're not actually using the RUN_PHPCS global you don't need to define it. Otherwise, the test scripts are set up here differently than they are in the patchtester repo so not much else I can say on that.

@andrepereiradasilva
Copy link
Contributor Author

ok thanks @mbabker
It's now testing on php 5.6 and php 7 too

@andrepereiradasilva
Copy link
Contributor Author

Guess what: it pass the php 7 test :)

@andrepereiradasilva andrepereiradasilva changed the title Make travis test on other php versions (5.6. and 7) Improve travis tests: test other php versions (5.6, 7 and hhvm); run code style tests only on one php version Mar 21, 2016
@infograf768
Copy link
Contributor

I honestly have no idea if this should be merged or not.
@javigomez , please decide.

@wilsonge wilsonge merged commit a232bf3 into joomla-projects:develop Mar 23, 2016
@javigomez
Copy link
Contributor

I see we are currently not running the system tests in travis so should not affect. Checking the builds after George's merge seems all to work okay.

@andrepereiradasilva andrepereiradasilva deleted the patch-2 branch March 23, 2016 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants