Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

[Work in progress] new styling #65

Closed

Conversation

drmenzelit
Copy link
Collaborator

@drmenzelit drmenzelit commented Sep 8, 2020

Summary of Changes

  • Several changes on scss files
  • added color variables
  • changed darken() to scale-color()
  • change to hsl colors
  • correct margins and paddings
  • structure changes in index.php to adapt to the new design

Testing Instructions

Install the PR and run npm ci
Use the theme switcher in the template

Expected result

You will see the design changing the colors

One issue: the current Cassiopeia logo doesn't change the color yet. If you want to see the color switcher working here, you need to write a title in the template configuration

@richard67
Copy link
Member

When enabled, the back-to-top button still has the colors of the core Cassiopeia, i.e. it doesn't follow the new color themes.

@richard67
Copy link
Member

With color theme "Winter", buttons like e.g. of the search or the login module have black text on black background. Only if hovered you can see the button text (black text on grey background).

@richard67
Copy link
Member

@drmenzelit With the winter color scheme, the active menu item is a very light grey text on white background. That is not a11y. When hovering, colors are ok.

@richard67
Copy link
Member

With spring color theme it is a very light green on white background, also not really good .

@richard67
Copy link
Member

@drmenzelit If you enter in the template style settings a site description, you will not see it in frontend because it is white text on white background (<div class="site-description">).

@richard67
Copy link
Member

@drmenzelit Question: Is it by purpose that when sticky header is enabled in the template style settings, only the logo and the search module are sticky but the menu is not?

@drmenzelit
Copy link
Collaborator Author

@drmenzelit If you enter in the template style settings a site description, you will not see it in frontend because it is white text on white background (<div class="site-description">).

It is corrected now

@drmenzelit
Copy link
Collaborator Author

@drmenzelit Question: Is it by purpose that when sticky header is enabled in the template style settings, only the logo and the search module are sticky but the menu is not?

I missed this as I took the nav outside the header.
As the header with logo & search in one line and the navigation on other line takes too much place, I decided to make only the navigation sticky.

@richard67
Copy link
Member

Much better now.

@richard67
Copy link
Member

The "Prev" and "Next" links for articles still use the core Cassiopeia colour:

snap-1

@drmenzelit
Copy link
Collaborator Author

The "Prev" and "Next" links for articles still use the core Cassiopeia colour:

I'm sure I changed it... it should use the color of the selected theme...

@richard67
Copy link
Member

Well the change was after my test.

@drmenzelit
Copy link
Collaborator Author

Well the change was after my test.

hahaha... I saw "still" and I thought it is a new comment... I'm tired...

@richard67 richard67 marked this pull request as draft September 12, 2020 17:17
@richard67
Copy link
Member

As we have discussed in the Team on Glip, we will stop this approach of the new design here for now in favour of PR #71 . I close this PR so that interested people and testers are not confused, but I suggest we don't delete the branch but keep it in case if we later want to come back to it.

@richard67 richard67 closed this Sep 13, 2020
@richard67 richard67 reopened this Sep 13, 2020
@richard67 richard67 changed the base branch from development to development-saved-before-pr-71-2020-09-13 September 13, 2020 19:02
@richard67 richard67 changed the base branch from development-saved-before-pr-71-2020-09-13 to development September 13, 2020 19:03
@richard67 richard67 changed the base branch from development to development-saved-before-pr-71-2020-09-13 September 13, 2020 19:03
@richard67 richard67 closed this Sep 13, 2020
@richard67 richard67 deleted the development-design2 branch October 28, 2020 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants