Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater for extensions #186

Closed
davidhavard opened this issue Apr 10, 2012 · 1 comment
Closed

Updater for extensions #186

davidhavard opened this issue Apr 10, 2012 · 1 comment

Comments

@davidhavard
Copy link

Hi

In libraries/joomla/updater/adaptors/extension.php on line 46 & 47 you will find the following two lines:

$this->current_update->folder = "";
$this->current_update->client_id = 1;

These bascially hardcode the updater to look for extensions that have a client_id of 1 and no folder. The problem here is that it effectively blocks updates for any extension that uses a client_id of 0 (site templates, libraries, plugins and modules) and any that use folders (plugins).

I am not familiar enough with this area of the Joomla code but a have had a look around it seems the best solution would be too include these in the update manifest using and tags. If they are not specified it can set these defaults to ensure backwards compatibility while allowing those who need it to get these updates working.

This code appears to have come out of this discussion: https://groups.google.com/forum/#!msg/joomla-dev-general/R4g0-Q2pWXk/SmLaJEsTUK0J where the suggested clumsy alternative seems the better option?

I am happy to make these changes and provide a patch unless someone has a better suggestion?

Thanks
Dave

@davidhavard
Copy link
Author

Ignore - found how to override this now.

wilsonge pushed a commit to wilsonge/joomla-cms that referenced this issue May 26, 2019
richard67 pushed a commit to richard67/joomla-cms that referenced this issue Apr 3, 2020
hans2103 pushed a commit to hans2103/joomla-cms that referenced this issue Nov 18, 2020
* Add comments, fix some published states

* fix copy/paste error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants