Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] WebClient.php deprecated elements on PHP8.1 #39960

Closed
imperpl opened this issue Feb 27, 2023 · 4 comments
Closed

[4.2] WebClient.php deprecated elements on PHP8.1 #39960

imperpl opened this issue Feb 27, 2023 · 4 comments
Labels
bug No Code Attached Yet PHP 8.x PHP 8.x deprecated issues

Comments

@imperpl
Copy link

imperpl commented Feb 27, 2023

Steps to reproduce the issue

webclient.php:
---(stripos($userAgent,
+++(stripos((string) $userAgent,

Expected result

Actual result

System information (as much as possible)

PHP 8.1

Additional comments

Deprecated lines 303, 308, 313, 318, 323, 328, 333, 338, 343

@joomdonation
Copy link
Contributor

Thanks @imperpl for reporting the issue. I reported it to Joomla framework application package repo joomla-framework/application#114. We will try to have it fixed ASAP and hopefully, have the fix includes in Joomla 4.3.

@Hackwar Hackwar added the bug label Mar 1, 2023
@Quy Quy added the PHP 8.x PHP 8.x deprecated issues label Aug 23, 2023
@brianteeman
Copy link
Contributor

Closing this here as the relevant issue as been created upstream

@richard67
Copy link
Member

Please test #42937 . Thanks in advance.

@richard67
Copy link
Member

For 5.x this issue has been fixed with PR #42945 , which will be part of the 5.1.0-beta1 coming up tomorrow.

For 4.4 it still needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug No Code Attached Yet PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

No branches or pull requests

7 participants