[5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8.1 deprecation #42937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #39960 #42317 #42830 .
Summary of Changes
This pull request (PR) updates the composer dependency to our application framework from 3.0.0 to 3.0.1 in the 5.1-dev branch to get the fix from joomla-framework/application#121 for the error mentioned in the issues referenced above. The update contains only the fix from that PR, there are no other changes from 3.0.0 to 3.0.1, see joomla-framework/application@3.0.0...3.0.1 .
I've made this PR for 5.1-dev because there is not any 5.0.4 release planned.
The change from this PR here is also included in PR #42945 , so if that gets merged, this one here is obsolete.
The issues were also reported for 4.4.x, which currently uses version 2.0.4 of the application framework.
As soon as the PR in the framework repository joomla-framework/application#122 has been merged into the 2.0-dev branch and a new 2.* release has been created, I will make a PR here for the 4.4-dev branch to get that update.
Testing Instructions
It is not enough to apply the changes of this PR with patchtester. It needs to use an installation package created by drone for this PR to make a new installation, or the update package or custom update URL created by drone for updating to 5.0-dev + this PR. All of that can be found here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42937/downloads/74142/ .
Or if you have a development environment with composer and npm, apply the change from this PR and then run
composer install
.Make sure that PHP errors are logged into a file by having
log_errors = On
anderror_log
pointing to a writable, existing file in PHP settings (php.ini).Set error reporting to maximum in Global Configuration.
Create a
GET Request
scheduled task.For the
Request URL
, specify the root of the installation.Click
Run Test
button.Check PHP error log.
Actual result BEFORE applying this Pull Request
stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/name/public_html/libraries/vendor/joomla/application/src/Web/WebClient.php on line XXX.
Expected result AFTER applying this Pull Request
No errors like the above mentioned.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed