Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8.1 deprecation #42937

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Mar 2, 2024

Pull Request for Issues #39960 #42317 #42830 .

Summary of Changes

This pull request (PR) updates the composer dependency to our application framework from 3.0.0 to 3.0.1 in the 5.1-dev branch to get the fix from joomla-framework/application#121 for the error mentioned in the issues referenced above. The update contains only the fix from that PR, there are no other changes from 3.0.0 to 3.0.1, see joomla-framework/application@3.0.0...3.0.1 .

I've made this PR for 5.1-dev because there is not any 5.0.4 release planned.

The change from this PR here is also included in PR #42945 , so if that gets merged, this one here is obsolete.

The issues were also reported for 4.4.x, which currently uses version 2.0.4 of the application framework.

As soon as the PR in the framework repository joomla-framework/application#122 has been merged into the 2.0-dev branch and a new 2.* release has been created, I will make a PR here for the 4.4-dev branch to get that update.

Testing Instructions

It is not enough to apply the changes of this PR with patchtester. It needs to use an installation package created by drone for this PR to make a new installation, or the update package or custom update URL created by drone for updating to 5.0-dev + this PR. All of that can be found here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42937/downloads/74142/ .

Or if you have a development environment with composer and npm, apply the change from this PR and then run composer install.

Make sure that PHP errors are logged into a file by having log_errors = On and error_log pointing to a writable, existing file in PHP settings (php.ini).

Set error reporting to maximum in Global Configuration.

Create a GET Request scheduled task.

For the Request URL, specify the root of the installation.

Click Run Test button.

Check PHP error log.

Actual result BEFORE applying this Pull Request

stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/name/public_html/libraries/vendor/joomla/application/src/Web/WebClient.php on line XXX.

Expected result AFTER applying this Pull Request

No errors like the above mentioned.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 added the PHP 8.x PHP 8.x deprecated issues label Mar 2, 2024
@richard67 richard67 changed the title [5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8,1 deprecation [5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8.1 deprecation Mar 2, 2024
@Quy
Copy link
Contributor

Quy commented Mar 2, 2024

Will be added soon. Up to now I can't really reproduce the issue.

Create a GET Request scheduled task.
For the Request URL, specify the root of the installation.
Click Run Test button.
See PHP error log.

@alikon
Copy link
Contributor

alikon commented Mar 3, 2024

I have tested this item ✅ successfully on 74309a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42937.

@richard67
Copy link
Member Author

Will be added soon. Up to now I can't really reproduce the issue.

Create a GET Request scheduled task. For the Request URL, specify the root of the installation. Click Run Test button. See PHP error log.

@Quy Thanks. Instructions added.

@laoneo
Copy link
Member

laoneo commented Mar 4, 2024

Closing this one as the package was updated as part of #42945.

@laoneo laoneo closed this Mar 4, 2024
@richard67 richard67 deleted the 5.1-dev-composer-update-joomla-application-3-0-1 branch March 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants