Skip to content

Fix Notice error for undefined array and avoid 404 when associations are disabled #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2016

Conversation

mannybiker
Copy link
Contributor

@mannybiker mannybiker commented May 9, 2016

Pull Request for Issue # .

Summary of Changes

Fix Notice error for undefined array and avoid 404 using the TOS with original language in case of multi-language association is disabled and an article from a different language than the current used is configured.

Testing Instructions

No Error Fix
Create a single language website environment and enable the profile plugins in order to request the custom TOS field in the user registration form
Check that no PHP Notice errors raise.

No Association Fix
Create a multi language website environment and enable the profile plugins in order to request the custom TOS field in the user registration form.
Select an article.
In the Language Filter plugin disable the Item Associations
Try to register using a different front end language than the one associated to the TOS article previously chosen.
Check that the TOS is correctly linked to the article originally selected, despite the current language is different (so avoiding 404)

… original language in case of multi-language association disabled
@zero-24
Copy link
Contributor

zero-24 commented May 10, 2016

I have tested this item ✅ successfully on e1b3e9a

Works good to me. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10366.

@jsubri
Copy link
Contributor

jsubri commented May 10, 2016

I have tested this item ✅ successfully on e1b3e9a

no more notice on mono-lingual site.
no more 404 on mono-lingual e.g. index.php/nl/component/users?view=registration (fr as default site language)
association works fine.
Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10366.

@infograf768
Copy link
Member

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10366.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 10, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 10, 2016
@rdeutz rdeutz merged commit 3a7765f into joomla:staging May 10, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants