[4.0] Refactor to return early, remove if depths and throw NotAllowed #29694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jun 18, 2020
richard67
reviewed
Jun 18, 2020
administrator/components/com_contenthistory/src/Model/HistoryModel.php
Outdated
Show resolved
Hide resolved
richard67
reviewed
Jun 18, 2020
administrator/components/com_contenthistory/src/Model/HistoryModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Jun 18, 2020
richard67
reviewed
Jun 18, 2020
administrator/components/com_contenthistory/src/Model/CompareModel.php
Outdated
Show resolved
Hide resolved
added 2 commits
June 19, 2020 09:48
Quy
reviewed
Jun 23, 2020
administrator/components/com_contenthistory/src/Model/HistoryModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jun 23, 2020
administrator/components/com_contenthistory/src/Model/HistoryModel.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 28b8b81 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Update doc blocks. |
This comment was marked as abuse.
This comment was marked as abuse.
|
I have tested this item ✅ successfully on 8ef304d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694. |
1 similar comment
|
I have tested this item ✅ successfully on 8ef304d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694. |
|
Thanks! |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jul 21, 2020
…outs * '4.0-dev' of github.com:joomla/joomla-cms: (612 commits) [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474) [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007) [4.0] Get menu directly in com_tags menu route helper (joomla#30039) Remove collapse when resizing from mobile to desktop (joomla#30132) [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870) [4.0] Webauthn gmp warning (joomla#29731) [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694) [4.0] CLI help text (joomla#29811) Feature/draggable typo fixes (joomla#29987) [4.0] Removing unnecessary workaround in finder indexer (joomla#30037) [4.0] Optimizing Smart Search for larger content (joomla#30008) [4.0] Fix js ajax for pre update checker (joomla#29980) [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097) [4.0][com_fields] Fix draggable sorting (joomla#30094) [4.0] Correct incorrect @return documentation (joomla#30092) [4.0] Menu items modal: adding missing filters (joomla#30087) short to long php open tags with echo (joomla#30089) Use new Toolbar (joomla#30085) [4.0] Center status/date created headers (joomla#29249) [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077) ... # Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php # installation/sql/postgresql/base.sql # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/SiteApplication.php
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
…joomla#29694) Refactor content history to return early, remove if depths and throw NotAllowed Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in this area, noticed bad use of if statements so refactored it a little
This fixes nothing - it just improves code readability and implements best practices
Summary of Changes
Refactor to apply concept of "return early" by throwing
NotAllowedexceptions if ACL failsTesting Instructions
use com_contenthistory - nothing should be broken, ACL should correctly error, this time with NotAllowed exceptions
Expected result
Nothing broken
Documentation Changes Required
None