Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][com_postinstall] Refactor using new Toolbar #30085

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jul 13, 2020

See PR #19670.

Summary of Changes

Refactor to use new Toolbar.

Testing Instructions

Click Post Installation Messages icon in the upper right corner.
Test buttons to ensure button working correctly as before.
View page source to see buttons markup same as before PR.

@Quy Quy added this to the Joomla 4.0 milestone Jul 13, 2020
@ceford
Copy link
Contributor

ceford commented Jul 13, 2020

I have tested this item ✅ successfully on 15e5b0d

Saw cod change on apply / remove patch. Checked button markup - same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30085.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 15e5b0d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30085.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 13, 2020
@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30085.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 13, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jul 13, 2020
@Quy Quy merged commit 3da9547 into joomla:4.0-dev Jul 13, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 13, 2020
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Jul 21, 2020
…outs

* '4.0-dev' of github.com:joomla/joomla-cms: (612 commits)
  [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474)
  [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007)
  [4.0] Get menu directly in com_tags menu route helper (joomla#30039)
  Remove collapse when resizing from mobile to desktop (joomla#30132)
  [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870)
  [4.0] Webauthn gmp warning (joomla#29731)
  [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694)
  [4.0] CLI help text (joomla#29811)
  Feature/draggable typo fixes (joomla#29987)
  [4.0] Removing unnecessary workaround in finder indexer (joomla#30037)
  [4.0] Optimizing Smart Search for larger content (joomla#30008)
  [4.0] Fix js ajax for pre update checker (joomla#29980)
  [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097)
  [4.0][com_fields] Fix draggable sorting (joomla#30094)
  [4.0] Correct incorrect @return documentation (joomla#30092)
  [4.0] Menu items modal: adding missing filters (joomla#30087)
  short to long php open tags with echo (joomla#30089)
  Use new Toolbar (joomla#30085)
  [4.0] Center status/date created headers (joomla#29249)
  [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077)
  ...

# Conflicts:
#	administrator/components/com_templates/src/View/Template/HtmlView.php
#	installation/sql/postgresql/base.sql
#	libraries/src/Application/AdministratorApplication.php
#	libraries/src/Application/SiteApplication.php
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@Quy Quy deleted the toolbar-postinstall branch December 1, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants