[4.0] Menu items modal: adding missing filters #30087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on d52f9ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087. |
|
The menu dropdown is at the top and not listed with the other dropdowns. |
|
I have tested this item ✅ successfully on d52f9ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087. |
Yep. Only way would be to create a specific css. Not sure what precisely as using flex is not my specialty. This would be for another pr.
This is fine. It's designed this way in backend. com_menu has a specific searchtools layout.
|
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087. |
|
Please merge as I have a PR for the css solving both the menutype custom-select display and the bcakground of the custom-select arrow |
|
See #30097 |
|
Thanks! |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jul 21, 2020
…outs * '4.0-dev' of github.com:joomla/joomla-cms: (612 commits) [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474) [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007) [4.0] Get menu directly in com_tags menu route helper (joomla#30039) Remove collapse when resizing from mobile to desktop (joomla#30132) [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870) [4.0] Webauthn gmp warning (joomla#29731) [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694) [4.0] CLI help text (joomla#29811) Feature/draggable typo fixes (joomla#29987) [4.0] Removing unnecessary workaround in finder indexer (joomla#30037) [4.0] Optimizing Smart Search for larger content (joomla#30008) [4.0] Fix js ajax for pre update checker (joomla#29980) [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097) [4.0][com_fields] Fix draggable sorting (joomla#30094) [4.0] Correct incorrect @return documentation (joomla#30092) [4.0] Menu items modal: adding missing filters (joomla#30087) short to long php open tags with echo (joomla#30089) Use new Toolbar (joomla#30085) [4.0] Center status/date created headers (joomla#29249) [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077) ... # Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php # installation/sql/postgresql/base.sql # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/SiteApplication.php
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Menus modals do not display filtering by Menu Type in backend and also in frontend.
Also, in frontend, no filtering by Parent Menu item
This PR corrects this so that filtering in modals is similar to filtering in menu tems Manager
Testing Instructions
Edit an article in backend and also in frontend.
Through CMS Content display a Menu Modal
Actual result BEFORE applying this Pull Request
Backend
Frontend
Expected result AFTER applying this Pull Request
Backend
Frontend