Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix Cassiopea searchtools alignment in modals #30077

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 12, 2020

Summary of Changes

Correct searchtools alignment to same position as backend.
I.e. bar should be aligned right in LTR, left in RTL

Testing Instructions

Edit Article in frontend. Select CMS Content article xtd.
Patch and run npm

Actual result BEFORE applying this Pull Request

Screen Shot 2020-07-12 at 08 57 22

Expected result AFTER applying this Pull Request

Screen Shot 2020-07-12 at 08 57 34

@richard67
Copy link
Member

I have tested this item ✅ successfully on 240d7b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30077.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jul 12, 2020

I have tested this item ✅ successfully on 240d7b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30077.

@Quy
Copy link
Contributor

Quy commented Jul 12, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30077.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jul 12, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 12, 2020
@Quy Quy added the PR-4.0-dev label Jul 12, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jul 12, 2020
@Quy Quy merged commit c0199a4 into joomla:4.0-dev Jul 12, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Jul 12, 2020
@infograf768 infograf768 deleted the 4.0_cassiopea_modal_js-stools branch July 13, 2020 04:59
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Jul 21, 2020
…outs

* '4.0-dev' of github.com:joomla/joomla-cms: (612 commits)
  [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474)
  [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007)
  [4.0] Get menu directly in com_tags menu route helper (joomla#30039)
  Remove collapse when resizing from mobile to desktop (joomla#30132)
  [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870)
  [4.0] Webauthn gmp warning (joomla#29731)
  [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694)
  [4.0] CLI help text (joomla#29811)
  Feature/draggable typo fixes (joomla#29987)
  [4.0] Removing unnecessary workaround in finder indexer (joomla#30037)
  [4.0] Optimizing Smart Search for larger content (joomla#30008)
  [4.0] Fix js ajax for pre update checker (joomla#29980)
  [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097)
  [4.0][com_fields] Fix draggable sorting (joomla#30094)
  [4.0] Correct incorrect @return documentation (joomla#30092)
  [4.0] Menu items modal: adding missing filters (joomla#30087)
  short to long php open tags with echo (joomla#30089)
  Use new Toolbar (joomla#30085)
  [4.0] Center status/date created headers (joomla#29249)
  [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077)
  ...

# Conflicts:
#	administrator/components/com_templates/src/View/Template/HtmlView.php
#	installation/sql/postgresql/base.sql
#	libraries/src/Application/AdministratorApplication.php
#	libraries/src/Application/SiteApplication.php
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants