Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Make sure hsts is only added on https sites #30902

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Oct 3, 2020

Pull Request for Issue #30886

Summary of Changes

Make sure hsts is only added on https sites

Testing Instructions

  • install 4.x on a http site (localhost for example)
  • enable hsts from the plugin
  • notice it is added to the header
  • apply this patch
  • see its gone
  • install this patch on a https site
  • make sure the hsts header is still added

Actual result BEFORE applying this Pull Request

HSTS is added on http sites

Expected result AFTER applying this Pull Request

HSTS is only added on https site.

Documentation Changes Required

None

@richard67
Copy link
Member

I have tested this item ✅ successfully on 48eee3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

1 similar comment
@hans2103
Copy link
Contributor

hans2103 commented Oct 5, 2020

I have tested this item ✅ successfully on 48eee3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

@Quy Quy removed the PR-4.0-dev label Oct 5, 2020
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Oct 5, 2020
@Quy
Copy link
Contributor

Quy commented Oct 5, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 5, 2020
@Quy Quy added the PR-4.0-dev label Oct 5, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 5, 2020
@HLeithner HLeithner merged commit d23c1b2 into joomla:4.0-dev Oct 6, 2020
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 6, 2020
@zero-24 zero-24 deleted the hsts_http branch October 6, 2020 09:12
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants