[4.0] Deprecate unused $iconOver

[N6REJ]

Pull Request for Issue #30211

Summary of Changes

Removes unused $iconOver param.
In 1.5 days this was used as an override ( not hover as stated now ) but has never been implemented in 4.+ so might as well just remove it. If its determined later that its useful we can always create it because as it is now it does NOTHING.

Testing Instructions

notice that toolbar icons display.
apply pr.
make sure toolbar icons still display.
hover over icons notice the icons remain.

Actual result BEFORE applying this Pull Request

nothing noted

Expected result AFTER applying this Pull Request

no visual changes.

Documentation Changes Required

Deprecate $iconOver in 5.x

[SharkyKZ]

This can't be removed without rewriting all uses of the method (B/C break) or adding B/C layer based on argument count.

[N6REJ]

@SharkyKZ well, the thing is its not even used!!!

joomla-cms/libraries/src/Toolbar/ToolbarHelper.php

Lines 102 to 111 in 425de68

	public static function custom($task = '', $icon = '', $iconOver = '', $alt = '', $listSelect = true, $formId = null)
	{
	$bar = Toolbar::getInstance('toolbar');
	// Strip extension.
	$icon = preg_replace('#\.[^.]*$#', '', $icon);
	// Add a standard button.
	$bar->appendButton('Standard', $icon, $alt, $task, $listSelect, $formId);
	}

if you add $iconOver to the appendButton function it becomes a text value in place of the normal text.. i.e. everything is out of sync.
in 3.x it an override NOT hover ( which makes sense since it would be damn hard to create a hover I think )
if you look @ the function its is brought in in the function variables but then does nothing.

I'm open as to what to do because clearly I'd have TONS of icon,icon to change to icon, if I'm to do it 100% correct.

As it stands its totally broken.
in 1.5x you'll see its used as an override
#30211 (comment)

In 3.x you'll see its being used as ??

THAT would be extremely easy to implement though I would still have tons of icon,icon to clean up.

[N6REJ]

@wilsonge thoughts?

[N6REJ]

After discussing @ length with @SharkyKZ we decided to leave the variable but deprecate its behavior.

[hans2103]

People might call for JToolbarHelper::custom('something', 'something', '', 'alt-text');. Removing it now will break b/c.
To make it deprecate is a good point. You can safely remove it in the next J version.

[brianteeman]

This should be closed #31211 (comment) and a new pr opened for the deprecation

[N6REJ]

This should be closed #31211 (comment) and a new pr opened for the deprecation

Thats what this is!

[brianteeman]

It is now you changed the title :)

[Quy]

I have tested this item ✅ successfully on 29a54db

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31211.}

[jwaisner]

I have tested this item ✅ successfully on 70cbc49

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31211.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31211.}

[richard67]

Thanks!