[3.10] [PHP 8.1] Fix HtmlDocument preg_split(): Passing null to $limit of type int #36775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # none, found and fixed directly here.
Summary of Changes
Fixes PHP 8.1 incompatibility
Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in libraries/src/Document/HtmlDocument.php on line 595
Actually, null would converts to 0, but it's the same as the function's default value of -1 that was expected there.
See https://www.php.net/manual/en/function.preg-split.php :
Testing Instructions
Open administrator backend in debug mode (with all incl. deprecation warnings turned on), and see this warning, then apply patch and see it disappear.
Actual result BEFORE applying this Pull Request
Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in libraries/src/Document/HtmlDocument.php on line 595
Expected result AFTER applying this Pull Request
warning disappeared.
Documentation Changes Required
none.