[4.3] Guided Tours - Eliminate tour blur event errors #41160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive tour before attempting to focus on the tour buttons!
joomla-cms-bot
added
NPM Resource Changed
4 tasks
|
I have tested this item ✅ successfully on 753db7a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160. |
|
I have tested this item ✅ successfully on 753db7a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160. |
Quy
changed the title
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160. |
|
Thank you Geraint @GeraintEdwards for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of PR #41159 for Joomla 4.3 instead
When you complete a tour and then interact with a targeted element the blur event listener is still attached and throws a javascript error
Pull Request for Issue # .
Summary of Changes
Check there is a tour active before attempting to focus on the tour step buttons
Testing Instructions
Run a tour e.g. How to create a menu item - cancel the tour before completing the title step (the same problem can exist in a completed tour).
Click in the 'title' field and then move it out (i.e. fire a blur event) the view the javascript console
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No error message in the console.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed