[5.0] Error Pages language #41934
Merged
[5.0] Error Pages language #41934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note to the strings in the installation language file that is used for building the error page. As seen in the screenshot several language packs have translated instead of localised the string or as in the case of German does not include the country part of the code resulting in unclear options @tecpromotion
|
I think this is OK. However, I noticed that line 164 has this: Should that have (ES) on the end? Or for consistency use French FR Went over to Crowdin for the first time for a year or so to see the comment in context. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41934. |
|
That is unrelated to this pr |
|
updated branch to retrigger drone |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note to the strings in the installation language file that is used for building the error page.
As seen in the screenshot several language packs have translated instead of localised the string or as in the case of German does not include the country part of the code resulting in unclear options
cc @tecpromotion
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed