-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Load Schema.org only in proper forms #42825
Conversation
I have tested this item ✅ successfully on 7d5f44f testing with latest Phoca Cart 5 Beta version: https://github.com/PhocaCz/PhocaCart/releases/download/5.0.0Beta/com_phocacart_v5.0.0Beta26.zip Before: After: Tested sucessfully ✓ This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825. |
I have tested this item ✅ successfully on 7d5f44f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825. |
I have tested this item ✅ successfully on 660b142 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825. |
I have tested this item ✅ successfully on 660b142 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825. |
Just curious, this PR is marked RTC since 3 months ago, but still not commited, so missing in 5.1.1 release, is there any issue with it? Should I add something? |
Thx |
Load and display scheme.org form only in contexts that component propagate as available.
Summary of Changes
Modified Schemaorg system plugin to load Schema form only in contexts, that are promoted by component as available.
Testing Instructions
Not testable on core, as com_content and com_contact both has only one edit view, one edit form. Need 3rd party component with support of SchemaorgServiceInterface.
Dev version of PhocaCart could be used (not released at the moment). If necessary I could prepare dummy component just for testing this.
Actual result BEFORE applying this Pull Request
If the component provides multiple forms, schema.org form is added to all of its forms, not only to forms declared in
getSchemaorgContexts function.
Expected result AFTER applying this Pull Request
Schema org fields are loaded only on proper forms.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed