Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Optimize LexSlu #1282 and expand NLU data #1283 #1331 #1332

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

rmtuckerphx
Copy link
Contributor

Proposed Changes

This PR adds an optimization so that the NLU API won't be called is the ASR output was called. This same time and $$.
Issue #1282

Lex allows you to specify required slots and it will do the slot filling for you. The additional properties on NLU data needed for this are state, confirmationState and messages. Issue #1283

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@rmtuckerphx rmtuckerphx changed the title V4/feature/optimize slu ✨ Optimize LexSlu #1282 and expand NLU data #1283 #1331 May 28, 2022
@jankoenig
Copy link
Member

Thank you @rmtuckerphx, this looks great!

I just updated the docs a bit, mainly for clarity (e.g. adding links to other docs). Could you take another look if that works for you? Thanks

@rmtuckerphx
Copy link
Contributor Author

Looks good @jankoenig
Thank you.

Copy link
Member

@aswetlow aswetlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jankoenig jankoenig merged commit 2d024c7 into jovotech:v4/dev Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants