Skip to content

Selector: Move from global to instance property category #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2017
Merged

Selector: Move from global to instance property category #1030

merged 1 commit into from
Mar 22, 2017

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Mar 20, 2017

Follows-up e3c9d15, which added it to the wrong category.

@Krinkle
Selector: Move from global to instance property category
f4c7a7b 
Follows-up e3c9d15, which added it to the wrong category.
@dmethvin dmethvin mentioned this pull request Mar 22, 2017
Open
21 tasks
dmethvin
dmethvin approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slug correctly indicates that this property was removed but the text says "it may be removed". There was a check next to that issue in #970 but I unchecked it and made a note. Let's keep that change separate.

@mgol mgol merged commit 65f99f9 into jquery:master Mar 22, 2017
@Krinkle Krinkle deleted the obj-selector branch March 22, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmethvin dmethvin dmethvin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krinkle @dmethvin @mgol