New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended text API documentation #460

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@johnnyreilly
Copy link
Contributor

johnnyreilly commented Mar 13, 2014

To allow number / boolean to be passed based on input from @dmethvin here.

Amended text documentation
To allow number / boolean to be passed based on input from @dmethvin
@kswedberg

This comment has been minimized.

Copy link
Member

kswedberg commented Mar 16, 2014

Thanks for this, @johnnyreilly. If we note that the argument can be Number or Boolean, I think we should also mention that they'll be converted to string representations. What do you think?

@johnnyreilly

This comment has been minimized.

Copy link
Contributor

johnnyreilly commented Mar 16, 2014

That sounds entirely sensible/useful! Shall I amend the comment in PR to reflect this?

@kswedberg

This comment has been minimized.

Copy link
Member

kswedberg commented Mar 16, 2014

Yes, please, and thank you.

@johnnyreilly

This comment has been minimized.

Copy link
Contributor

johnnyreilly commented Mar 17, 2014

Hope this comment looks okay @kswedberg - let me know if it needs tweaking.

@johnnyreilly

This comment has been minimized.

Copy link
Contributor

johnnyreilly commented Mar 18, 2014

No problem - see latest commit (I uppercased the "S" on "string" to fall in line with Number and Boolean BTW)

@kswedberg

This comment has been minimized.

Copy link
Member

kswedberg commented Mar 18, 2014

Beautiful! Thanks, @johnnyreilly. One last thing: we'd like everyone who contributes to any of jQuery's repos to sign a Contributor License Agreement (CLA). Would you mind doing that at http://contribute.jquery.org/CLA/? Let me know when that's done, and I'll push your changes posthaste.

@johnnyreilly

This comment has been minimized.

Copy link
Contributor

johnnyreilly commented Mar 18, 2014

Done!

@kswedberg kswedberg closed this in 58be0dd Mar 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment