Downstream test: ignore Recast since its master is flaky #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recast's TypeScript tests often fail spuriously, sometimes in conjuction with GraphQL, so let's isolate us from it.
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 4056 4056
Branches 717 717
======================================
Hits 4056 4056Continue to review full report at Codecov.
|
ariya
added a commit
to ariya/esprima
that referenced
this pull request
Jun 15, 2018
Recast's TypeScript tests often fail spuriously, sometimes in conjuction with GraphQL, so let's isolate us from it. Closes jquerygh-1931
ariya
added a commit
to ariya/esprima
that referenced
this pull request
Jun 16, 2018
Recast's TypeScript tests often fail spuriously, sometimes in conjuction with GraphQL, so let's isolate us from it. Closes jquerygh-1931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recast's TypeScript tests often fail spuriously, sometimes in conjuction with GraphQL,
so let's isolate us from it.