Tests: Refactor iframe tests to be more like core #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the arg order and basic approach closer to what is now being used in core. It also removes some of the boilerplate from the iframe html pages and moves it to a new iframeTest.js file that they all include.
|
By analyzing the blame information on this pull request, we identified @mgol, @markelog and @gibson042 to be potential reviewers |
|
I landed this because I have a few other things that depend on it, feel free to comment if you think it needs work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the arg order and basic approach closer to what is now being used in
core. It also removes some of the boilerplate from the iframe html pages and
moves it to a new iframeTest.js file that they all include.