Event: Warn on fixHooks case when it has no props and only filter #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquery#190 The single iframe test was getting too hairy so it was refactored into two separate tests, on for props and one for fixHooks.
| @@ -11,16 +11,19 @@ jQuery.event.fix = function( originalEvent ) { | |||
| props = jQuery.event.props; | |||
|
|
|||
| if ( props.length ) { | |||
| migrateWarn( "jQuery.event.props are deprecated and removed" ); | |||
| migrateWarn( "jQuery.event.props are deprecated and removed: " + props.join() ); | |||
There was a problem hiding this comment.
This seemed useful info, at least it's something to search for and the name gives a clue as to what might have added it.
| while ( props.length ) { | ||
| jQuery.event.addProp( props.pop() ); | ||
| if ( fixHook && !fixHook._migrated_ ) { | ||
| fixHook._migrated_ = true; |
There was a problem hiding this comment.
I struggled with exactly how to do this. Alternatively I could keep some sort of flag inside Migrate as to whether I've warned yet for this fixHook.
|
Coverage really didn't decrease, coveralls doesn't see the tests that happen in the iframe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
The single hooks iframe test was getting hairy so the jQuery.event.props test was moved into a separate test.