Skip to content

Conversation

LaurentBarbareau
Copy link
Contributor

Consistency with cfc0f4e

@mention-bot
Copy link

@LaurentBarbareau, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dmethvin, @markelog and @mgol to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.5% when pulling f0f334a on LaurentBarbareau:patch-3 into 057e1f4 on jquery:master.

@mgol
Copy link
Member

mgol commented Aug 29, 2016

Thanks for the PR but let's keep all the related changes in #222; we'd like to land them in one commit anwyay.

@mgol mgol closed this Aug 29, 2016
@dmethvin
Copy link
Member

@LaurentBarbareau Just make another commit on your patch-1 branch over in #222 and push it. When we land it we will squash the two commits. The reason for keeping it in one place is to be sure that the master branch is consistent as often as possible rather than having the work be half-done in two different commits. Thanks for your help, if you need assistance with this just post a question in #222!

@LaurentBarbareau
Copy link
Contributor Author

I understand why you want to keep all in #222 but I don't know how to do.
Can I make it from the GitHub web interface?
thx

@dmethvin
Copy link
Member

I didn't know the answer before but just found out. 😸

Go to the jquery fork in your account and find the patch-1 branch, it's at https://github.com/LaurentBarbareau/jquery-migrate/tree/patch-1 . Then go to the file you want to edit and click the little pencil icon Make the change and at the bottom it should have "Commit directly to the patch-1 branch". That will add another commit to your pull request!

@dmethvin
Copy link
Member

Normally the Github web interface isn't flexible enough, since it isn't possible to create and run additional unit tests that way. For documentation issues like this it is fine though.

@LaurentBarbareau
Copy link
Contributor Author

Thank you.
Done.

@LaurentBarbareau LaurentBarbareau deleted the patch-3 branch August 30, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants