Core: Warn on use of jQuery.holdReady() #247
Conversation
|
@dmethvin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgol, @markelog and @gibson042 to be potential reviewers. |
|
|
||
| expectWarning( "jQuery.holdReady", 1, function() { | ||
| jQuery.holdReady( true ); | ||
| jQuery.holdReady( false ); |
There was a problem hiding this comment.
Just to be sure I don't get two warnings.
|
@Krinkle I remember you were using it somewhere? |
|
@markelog I used to use it at Wikipedia by calling It was mainly there to work around a bug in Firefox (as well as minor optimisation to trigger the event when its "early" enough for us, which was a bad idea in hindsight). The bug was actually caused by some fragile logic on our end, fixed and refactored in 2014, and the For third-party users of MediaWiki, this was released in 1.22.0 (Dec 2013) and removed in 1.26.0 (Nov 2015). The current stable (1.28) and LTS (1.27) no longer have this, however we do have a few months left until May 2017 before MediaWiki 1.23 (legacy LTS) reaches end-of-life. |
|
@Krinkle thank you for the thoughtful comment, looks like we are in the clear :) |
Fixes #225
jQuery core includes two implementations of
jQuery.holdReady()and it would be tough at this point to anticipate how we might rewrite it, so I skipped trying to fill it for now at least.