New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cleanups and unit tests from 4.0 branch #145

Open
dmethvin opened this Issue Jul 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@dmethvin
Member

dmethvin commented Jul 15, 2015

If none of these are breaking changes, stay with 3.x version. See #142.

@brandonaaron

This comment has been minimized.

Show comment
Hide comment
@brandonaaron

brandonaaron Jul 15, 2015

Contributor

In the 4.0.x branch I swapped the delta signs to match the newer wheel event (https://github.com/jquery/jquery-mousewheel/tree/4.0.x#older-versions). Off the top of my head that and not passing the delta values to the handler (they are only attached as properties of the event) are the two breaking changes.

Contributor

brandonaaron commented Jul 15, 2015

In the 4.0.x branch I swapped the delta signs to match the newer wheel event (https://github.com/jquery/jquery-mousewheel/tree/4.0.x#older-versions). Off the top of my head that and not passing the delta values to the handler (they are only attached as properties of the event) are the two breaking changes.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 19, 2016

Member

If we're swapping the delta signs, maybe we should also get the event renamed to wheel to reduce confusion? It would also make it easier for external code to work with both old & new versions of the plugin if needed.

Member

mgol commented Oct 19, 2016

If we're swapping the delta signs, maybe we should also get the event renamed to wheel to reduce confusion? It would also make it easier for external code to work with both old & new versions of the plugin if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment