New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Implemented changelog generation #8

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@scottgonzalez
Member

scottgonzalez commented Dec 6, 2013

I haven't tested this yet, but figured I'd push in case someone else gets around to testing before I do.

TODO:

  • Filter our PRs
@jzaefferer

This comment has been minimized.

Member

jzaefferer commented Jan 3, 2014

Could you rebase this? The PR now seems to include a bunch of unrelated commits, e.g. adding cdn.js, which doesn't belong here.

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Jan 3, 2014

Rebased.

@jzaefferer

This comment has been minimized.

Member

jzaefferer commented Jan 3, 2014

This currently fails with Error: Cannot find module 'github'. Will try again later and dig a bit.

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Jan 3, 2014

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Feb 12, 2014

We need to filter out pull request which show up as issues through the API.

@gnarf

This comment has been minimized.

Member

gnarf commented Dec 21, 2014

Going through some old pulls, is this dead or should we revive it?

@arschmitz

This comment has been minimized.

Member

arschmitz commented Dec 21, 2014

This is on me iv promised to test twice :-(

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Dec 22, 2014

It's definitely not ready to be merged. There are at least two issues that are documented in my last two comments.

@gnarf

This comment has been minimized.

Member

gnarf commented Dec 22, 2014

@scottgonzalez : could you maybe edit the open issues into the main pull as * [ ] items to be checked off?

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Jan 5, 2015

Did a minor update and added the PR filtering to the main description. In case you can't tell, I haven't actually tested this, I've just been waiting for someone managing a project that uses GitHub to finish this. At this point, it won't rebase cleanly.

@dmethvin

This comment has been minimized.

Member

dmethvin commented Jan 5, 2015

Pinging @timmywil, he's working on several build-related tasks for our next release.

scottgonzalez added some commits Mar 17, 2015

@scottgonzalez

This comment has been minimized.

Member

scottgonzalez commented Mar 18, 2015

I've rebased and mostly reimplemented this. It handles changelog generation, but not contributor gathering. This is ready for review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment