Skip to content

repo: Install npm dependencies with the --no-save flag #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Jan 20, 2018

This fixes jquery/jquery#3947

  • Also, I'm not sure -q does anything anymore. It's not documented in the npm install docs.

Copy link

@frank-dspeed frank-dspeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silic0nS0ldier
Copy link

-q sets logging to warnings or greater. Only documented at their repo though. Still works as of npm 5.6.0.

@markelog
Copy link
Member

It is documented, see – https://docs.npmjs.com/misc/config

Copy link
Member

@markelog markelog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems -q is there to remove needless output?

@timmywil
Copy link
Member Author

Maybe our definition of needless differs, but I don't see any needless output. This may differ from older versions because of the new loading animation.

@markelog
Copy link
Member

markelog commented Jan 22, 2018 via email

@Silic0nS0ldier
Copy link

@markelog Huh. So it is. Was expecting it to be under cli. Thanks for the pointer.

The only thing -q seems to suppress under normal use is the package-lock.json creation notice, which won't happen anyway due to --no-save. It likely also stopped the dependency tree print out in older versions.

Huh. As of v5 of NPM, the --save switch is the default. Chances are someone updated their version of npm (either directly or via a node update). Another change like this is unlikely to hit again soon (if ever), but it might be worth locking down the npm version if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3.3.0 bundled a package.json with "dependencies" that is not empty, leads to npm errors
5 participants