Jscs v2 #1589
Jscs v2 #1589
Conversation
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
Ref #14246
|
@scottgonzalez fixed the commit message |
| jscs: { | ||
| all: { | ||
| options: { | ||
| requireCapitalizedComments: null | ||
| config: ".jscsrc" |
There was a problem hiding this comment.
Is this actually needed? If there's a bug with maxErrors we should report it and override maxErrors, but keep letting it use its default config file finding.
There was a problem hiding this comment.
I assume you meant to comment on the max errors line above but yeah its not a bug its just the default is 50.
There was a problem hiding this comment.
No, I meant this line. The default config: true should work just fine. In my own limited testing it seemed like jscs wouldn't report any errors unless I set config explicitly. Based on our conversation elsewhere it sounded like there's a bug where jscs wouldn't report any errors at all when there are more errors than maxErrors.
There was a problem hiding this comment.
For the config file yes true should be fine. The bug you mentioned with max errors was already reported to them jscs-dev/node-jscs#1722 it is unrelated to this as its only related to running with fix. I added it here just because the normal max is 50 and i believe we want to output them all.
|
Apart from the config property above, this looks good. It even fails when there's an error! |
More style updates to please jscs moved overrides to .jscsrc