Skip to content

Jscs v2 #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

Jscs v2 #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a996cb3
Selectmenu: Style updates
arschmitz Aug 24, 2015
c8a50db
Tooltip: Style updates
arschmitz Aug 24, 2015
2c98903
Tabs: Style updates
arschmitz Aug 24, 2015
801875f
Spinner: Style updates
arschmitz Aug 24, 2015
a718275
Sortable: Style updates
arschmitz Aug 24, 2015
369effd
Slider: Style updates
arschmitz Aug 24, 2015
03717b3
Selectable: Style updates
arschmitz Aug 24, 2015
dfdcafd
Resizable: Style updates
arschmitz Aug 24, 2015
9bf3b5f
Progressbar: Style updates
arschmitz Aug 24, 2015
27a0e38
Mouse: Style updates
arschmitz Aug 24, 2015
1b0d148
Menu: Style updates
arschmitz Aug 24, 2015
e62e6c2
Droppable: Style updates
arschmitz Aug 24, 2015
ec215f8
Draggable: Style updates
arschmitz Aug 24, 2015
f7c3d2a
Dialog: Style updates
arschmitz Aug 24, 2015
118936e
Datepicker: Style updates
arschmitz Aug 24, 2015
4cbb6b2
Button: Style updates
arschmitz Aug 24, 2015
d9b38e5
Autocomplete: Style updates
arschmitz Aug 24, 2015
c23444a
Widget: Style updates
arschmitz Aug 24, 2015
e41ee10
Effects: Style updates
arschmitz Aug 24, 2015
702e2db
Position: Style updates
arschmitz Aug 24, 2015
4b5e616
FormRestMixin: Style updates
arschmitz Aug 24, 2015
948714f
Build: Style updates
arschmitz Aug 24, 2015
f703bd2
Build: squash .jscsrc fixup
arschmitz Aug 25, 2015
4219332
Spinner: Update to use camelcase identifiers
arschmitz Aug 25, 2015
9737a5f
Widget: Update to use camelCase identifiers
arschmitz Aug 25, 2015
97b0e0b
Build: Remove requireCamelCaseOrUpperCaseIdentifiers: null from jscs
arschmitz Aug 25, 2015
d83d24f
Build: bump jscs version
arschmitz Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .jscsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
{
"preset": "jquery",

// disabled until `widget_slice` et al are addressed
"requireCamelCaseOrUpperCaseIdentifiers": null,
// This is currently unenforcable see https://github.com/jscs-dev/node-jscs/issues/1686
"requireCapitalizedComments": null,

// Until we drop IE8 this prevents things like warning on float keyword
"es3": true,

// We want to output all errors
"maxErrors": 1000000,

// Ref https://github.com/jquery/contribute.jquery.org/issues/80#issuecomment-45253460
"maximumLineLength": null
Expand Down
3 changes: 1 addition & 2 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,10 @@ grunt.initConfig({
}
},

// Remove the requireSpacesInsideParentheses override once everything is fixed
jscs: {
all: {
options: {
requireCapitalizedComments: null
config: ".jscsrc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually needed? If there's a bug with maxErrors we should report it and override maxErrors, but keep letting it use its default config file finding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant to comment on the max errors line above but yeah its not a bug its just the default is 50.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I meant this line. The default config: true should work just fine. In my own limited testing it seemed like jscs wouldn't report any errors unless I set config explicitly. Based on our conversation elsewhere it sounded like there's a bug where jscs wouldn't report any errors at all when there are more errors than maxErrors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the config file yes true should be fine. The bug you mentioned with max errors was already reported to them jscs-dev/node-jscs#1722 it is unrelated to this as its only related to running with fix. I added it here just because the normal max is 50 and i believe we want to output them all.

},
files: {
src: [ "demos/**/*.js", "build/**/*.js", "tests/**/*.js", "ui/**/*.js" ]
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"grunt-esformatter": "0.2.0",
"grunt-git-authors": "2.0.0",
"grunt-html": "4.0.1",
"grunt-jscs": "1.5.0",
"grunt-jscs": "2.1.0",
"load-grunt-tasks": "0.3.0",
"rimraf": "2.1.4",
"testswarm": "1.1.0"
Expand Down
Loading