Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Position: Take margin into account when performing collisions. Fixes #5766 - position: collision should take margin into account #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

bhollis commented Sep 1, 2010

This is a fix for http://dev.jqueryui.com/ticket/5766, making the collision functions for jquery.ui.position take into account the margin on the element being positioned. This will be really helpful if somebody wants to keep a "buffer" around a positioned element, or make sure the element's drop shadow (using -moz-box-shadow) doesn't go off the page and cause scrollbars.

Position: Take margin into account when performing collisions. Fixes …
…#5766 - position: collision should take margin into account
Owner

scottgonzalez commented Sep 3, 2010

Thanks. I tweaked the commit a bit for performance and landed it in 4b9d5d1

scottgonzalez pushed a commit to scottgonzalez/jquery-ui that referenced this pull request Oct 17, 2011

mikesherov pushed a commit to mikesherov/jquery-ui that referenced this pull request Jan 14, 2013

Merge pull request #3 from mikesherov/clip
abstract out createPlaceholder

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment