Skip to content

Sortable: Apply cursor stylings to the helper directly instead of the body of document #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fracmak
Copy link
Contributor

@fracmak fracmak commented May 19, 2011

Sortable: Apply cursor stylings to the helper directly instead of the body of the page to make certain that the style sticks. Fixes #7389 - Sortable 'cursor' option does not override cursor settings for affected DOM object

I've tested this fix in Firefox 4, 3.6, IE 6,7,8,9, and Chrome 11

… body of the page to make certain that the style sticks. Fixes #7389 - Sortable 'cursor' option does not override cursor settings for affected DOM object
@rdworth
Copy link
Contributor

rdworth commented May 20, 2011

This change is not compatible with the cursorAt option http://docs.jquery.com/UI/Sortable#option-cursorAt

@fracmak
Copy link
Contributor Author

fracmak commented May 20, 2011

Hmmm. The only thing that would work would be adding !important to the cursor class on the body, which doesn't seem allowed outside of classes in a style sheet. I could always dynamically create a class, but I get a bad taste in my mouth just thinking about it. :-P

@scottgonzalez
Copy link
Member

I think we'll just need to look at this again when we do the sortable rewrite.

@Haraldson
Copy link

What is the reason for applying these styles with JavaScript – and that in a fashion that makes overriding the cursor hard or impossible? I’m trying to add cursor-grabbing (with -wekbit- and -moz-) using CSS (I know, crazy, right?) to .ui-sortable-helper, with no luck thus far.

@scottgonzalez
Copy link
Member

@Haraldson The rewrite won't do that.

@Haraldson
Copy link

@scottgonzalez Rewrite, as in a total rewrite/new major version of UI? Sorry, haven’t been following the project that closely, but if that’s the case, that’s really good news! :)

@scottgonzalez
Copy link
Member

Yes, though this is not the appropriate location to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants