Sortable: inject css rule to style the cursor. Fixed #7389 - 'cursor' option didn't override CSS cursor settings #914
Conversation
…sortable: 'cursor' option didn't override CSS cursor settings
|
Considering the fact that this would prevent any mouse events from firing on "real" elements during a sort, I don't think this is a good solution. |
|
I guess if we just injected something like |
|
Appending a stylesheet does not work with IE, but the old inline css change to the body does, so I added that back. Tested for Google Chrome v24, Firefox 17 and 18, Safari 5.1.7, Opera 12.14 and IE 7, 8 and 9. |
| @@ -86,6 +86,16 @@ $.widget("ui.sortable", $.ui.mouse, { | |||
|
|
|||
| }, | |||
|
|
|||
| _createCursorStylesheet: function( cursor ) { | |||
| $stylesheet = $("<style>"); | |||
There was a problem hiding this comment.
Does $( "<style>*{ cursor: move !important; }</style>" ).appendTo( "body" ) not work in all browsers? Last I checked (a few years ago), it did.
There was a problem hiding this comment.
Indeed it does! Except for IE.
|
We're getting close :-) There are a few changes that need to be made, but before having you change stuff that might go away, can you see if using |
|
Since this is going to land soon, can you sign our CLA? |
|
Nope, adding |
|
Ok, thanks for checking. I didn't think it would make a difference, but figured we should try all possible tricks before having different logic for different browsers. I'll do inline comment for the changes. |
| this._storedCursor = $("body").css("cursor"); | ||
| } | ||
| $("body").css("cursor", o.cursor); | ||
| if( o.cursor !== "auto" ) { // cursor option |
There was a problem hiding this comment.
This should probably be !o.cursor || o.cursor !== "auto". "auto" is a silly default, null should've been used, but that's out of scope for this change.
There was a problem hiding this comment.
I think you meant o.cursor && o.cursor !== "auto" ;-)
|
All done. |
|
Thanks, landed in a692bf9. |
Fixed #7389 - sortable: 'cursor' option didn't override CSS cursor settings
Overrides the CSS cursor styles of the page's elements by injecting a stylesheet.