Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Button: Strange space between buttons in IE 7. Fixed #5253 Toolbar demo ... #848

Closed
wants to merge 1 commit into from

2 participants

lordt Mike Sherov
lordt

...ugly in IE

Previous pull requests:
#265
#292

  1. I changed the toolbar.html, so now it also works in IE 6, how ever I
    don't paste the display:inline-block in #toolbar, because it produces
    not this same result, as without it.

  2. About zoom:1 in ui-widget-header (jquery.ui.theme.css).
    Zoom is IE-only property, so I tested many demos in IE (versions: 6,7,8,9) and there
    is no problem with zoom:1 on all versions IE >= 6. So I don't see any
    contra to commit it into jquery-ui css files.

lordt

@mikesherov @scottgonzalez I made changes. And I agreed CLA (whatever it is). But I want you know to that I'm quite disappointed the time my pull request has been processed. If it had been merged earlier, then hadn't be any problems.

Sorry for my english.

Mike Sherov
Collaborator

@lordt, this is how it goes with open source software, it's in fits and starts and sometimes from an outside perspective, it's hard to see what effort it takes to get the rest of the project working. In the 7 months that this pull was open, the team was busy working their butts off elsewhere around the project.

It's hard from your perspective to see the blood sweat and tears that @scottgonzalez, @jzaefferer, @kborchers, and @gnarf37 put into this project if you focus solely on this pull request. No reason to be disappointed.

Mike Sherov
Collaborator

Thanks, landed in e77edc6

Mike Sherov mikesherov closed this November 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 27, 2012
lordt Button: Strange space between buttons in IE 7. Fixed #5253 Toolbar de…
…mo ugly in IE
f300f28
This page is out of date. Refresh to see the latest.
7  demos/button/toolbar.html
@@ -11,7 +11,12 @@
11 11
 	<link rel="stylesheet" href="../demos.css">
12 12
 	<style>
13 13
 	#toolbar {
14  
-		padding: 10px 4px;
  14
+		padding: 11px 4px 9px 4px;
  15
+	}
  16
+
  17
+	/* support: IE7 */
  18
+	*:first-child+html #toolbar {
  19
+		padding: 4px 0px 4px 5px;
15 20
 	}
16 21
 	</style>
17 22
 	<script>
2  themes/base/jquery.ui.button.css
@@ -42,7 +42,7 @@ button.ui-button-icons-only {
42 42
 
43 43
 /* button text element */
44 44
 .ui-button .ui-button-text {
45  
-	display: block;
  45
+	display: inline-block;
46 46
 	line-height: 1.4;
47 47
 }
48 48
 .ui-button-text-only .ui-button-text {
1  themes/base/jquery.ui.theme.css
@@ -41,6 +41,7 @@
41 41
 	background: #cccccc/*{bgColorHeader}*/ url(images/ui-bg_highlight-soft_75_cccccc_1x100.png)/*{bgImgUrlHeader}*/ 50%/*{bgHeaderXPos}*/ 50%/*{bgHeaderYPos}*/ repeat-x/*{bgHeaderRepeat}*/;
42 42
 	color: #222222/*{fcHeader}*/;
43 43
 	font-weight: bold;
  44
+	zoom: 1;
44 45
 }
45 46
 .ui-widget-header a { color: #222222/*{fcHeader}*/; }
46 47
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.