learn.jquery.com: remove templating for contributors attributions #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| background-image: -webkit-linear-gradient(top, #ffea94, #FFEA5E); | ||
| background-image: -moz-linear-gradient(top, #ffea94, #FFEA5E); | ||
| background-image: -ms-linear-gradient(top, #ffea94, #FFEA5E); | ||
| background-image: -o-linear-gradient(top, #ffea94, #FFEA5E); |
There was a problem hiding this comment.
Ouch, we don't have unprefixed gradients here; that's bad. Most of these prefixes are no longer needed btw.
There was a problem hiding this comment.
True. But that's not something for this PR ;-) The only reason this appears in the diff is because the removed trailing whitespace.
There was a problem hiding this comment.
I've created an issue for that so that we don't continue this unrelated discussion here. See #335.
This was referenced Jan 3, 2015
arthurvr
force-pushed
the
update-learn-theme
branch
from
bb7fe7c to
92f3f2e
Compare
arthurvr
force-pushed
the
update-learn-theme
branch
from
92f3f2e to
297d80d
Compare
|
@mzgol Updated my PR to include the trailing whitespace again. |
|
According PR in |
|
Landed in 6617499, forgot to add the ref for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this yet, It must be merged the same time with a PR in the
learn.jquery.comrepo. Just open for review now.As discussed in jquery/learn.jquery.com#602, this section is going to get replaced by a link to the Github contributor graphs.
Also: seems like my editor removed some trailing whitespace in the css file, don't care about it 🍻