Skip to content
Permalink
Browse files
Fix comment about Safari shortfalls.
  • Loading branch information
dmethvin committed Jan 29, 2013
1 parent aa3c929 commit 451d0c37d9297598743b1372bf623d4b7d38e951
Showing 1 changed file with 1 addition and 1 deletion.
@@ -411,7 +411,7 @@ jQuery.extend({
if ( obj == null ) {
return String( obj );
}
// Support: Safari <5.1 (functionish RegExp)
// Support: Safari <=5.1 (functionish RegExp)
return typeof obj === "object" || typeof obj === "function" ?
class2type[ core_toString.call(obj) ] || "object" :
typeof obj;

8 comments on commit 451d0c3

@domenic
Copy link

@domenic domenic commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww, no IE8 but yes Safari 5.1? That poor browser doesn't even have Function.prototype.bind

@rwaldron
Copy link
Member

@rwaldron rwaldron commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari 5.1 is nearly 2 years old and actually outside of our support range, however 5.1.7 is still the "current -1"

@rwaldron
Copy link
Member

@rwaldron rwaldron commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... seems like a weird thing to nitpick.

@domenic
Copy link

@domenic domenic commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I just hate Safari 5.1 with a passion, so was curious whether I could use "jQuery 2.0 doesn't support it!" in the same way I use that for IE8.

@rwaldron
Copy link
Member

@rwaldron rwaldron commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an awful browser... pretending to be modern, just a fraud.

If this issue doesn't exist in 5.1.7, we shouldn't be special casing it.

@dmethvin
Copy link
Member Author

@dmethvin dmethvin commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if all the iOS/Mac users have switched to Safari 6 then sure, but I suspect there are a lot of them still around. And adding another condition to support it here isn't nearly as bad as the 10% of the library we stripped out for oldIE.

@dmethvin
Copy link
Member Author

@dmethvin dmethvin commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And lets be clear about how broken Safari 5.1.7 is if we don't add this half-line of support: http://swarm.jquery.org/job/2433

@rwaldron
Copy link
Member

@rwaldron rwaldron commented on 451d0c3 Jan 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch :hurtrealbad:

Please sign in to comment.