Permalink
8 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aww, no IE8 but yes Safari 5.1? That poor browser doesn't even have
Function.prototype.bind
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safari 5.1 is nearly 2 years old and actually outside of our support range, however 5.1.7 is still the "current -1"
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also... seems like a weird thing to nitpick.
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I just hate Safari 5.1 with a passion, so was curious whether I could use "jQuery 2.0 doesn't support it!" in the same way I use that for IE8.
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an awful browser... pretending to be modern, just a fraud.
If this issue doesn't exist in 5.1.7, we shouldn't be special casing it.
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well if all the iOS/Mac users have switched to Safari 6 then sure, but I suspect there are a lot of them still around. And adding another condition to support it here isn't nearly as bad as the 10% of the library we stripped out for oldIE.
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And lets be clear about how broken Safari 5.1.7 is if we don't add this half-line of support: http://swarm.jquery.org/job/2433
451d0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch