Skip to content
Permalink
Browse files

Fix #12336. Ensure oldIE really does .empty() selects.

  • Loading branch information...
dmethvin committed Jan 6, 2013
1 parent b45c775 commit bbdf957e9886212cac9b72ee9dedd73118aa8427
Showing with 14 additions and 2 deletions.
  1. +6 −0 src/manipulation.js
  2. +8 −2 test/unit/manipulation.js
@@ -192,6 +192,12 @@ jQuery.fn.extend({
while ( elem.firstChild ) {
elem.removeChild( elem.firstChild );
}

// If this is a select, ensure that it displays empty (#12336)
// Support: IE<9
if ( elem.options && jQuery.nodeName( elem, "select" ) ) {
elem.options.length = 0;
}
}

return this;
@@ -1829,7 +1829,7 @@ test( "detach() event cleaning ", 1, function() {

test("empty()", function() {

expect( 3 );
expect( 6 );

equal( jQuery("#ap").children().empty().text().length, 0, "Check text is removed" );
equal( jQuery("#ap").children().length, 4, "Check elements are not removed" );
@@ -1838,7 +1838,13 @@ test("empty()", function() {
var j = jQuery("#nonnodes").contents();
j.empty();
equal( j.html(), "", "Check node,textnode,comment empty works" );
});

// Ensure oldIE empties selects (#12336)
notEqual( $("#select1").find("option").length, 0, "Have some initial options" );
$("#select1").empty();
equal( $("#select1").find("option").length, 0, "No more option elements found" );
equal( $("#select1")[0].options.length, 0, "options.length cleared as well" );
});

test( "jQuery.cleanData", function() {

0 comments on commit bbdf957

Please sign in to comment.
You can’t perform that action at this time.