Fix #12336. Ensure oldIE really does .empty() selects.

jquery · Jan 6, 2013 · bbdf957 · bbdf957
1 parent b45c775
commit bbdf957
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -192,6 +192,12 @@ jQuery.fn.extend({
 			while ( elem.firstChild ) {
 				elem.removeChild( elem.firstChild );
 			}
+
+			// If this is a select, ensure that it displays empty (#12336)
+			// Support: IE<9
+			if ( elem.options && jQuery.nodeName( elem, "select" ) ) {
+				elem.options.length = 0;
+			}
 		}
 
 		return this;

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -1829,7 +1829,7 @@ test( "detach() event cleaning ", 1, function() {
 
 test("empty()", function() {
 
-	expect( 3 );
+	expect( 6 );
 
 	equal( jQuery("#ap").children().empty().text().length, 0, "Check text is removed" );
 	equal( jQuery("#ap").children().length, 4, "Check elements are not removed" );
@@ -1838,7 +1838,13 @@ test("empty()", function() {
 	var j = jQuery("#nonnodes").contents();
 	j.empty();
 	equal( j.html(), "", "Check node,textnode,comment empty works" );
-});
+
+	// Ensure oldIE empties selects (#12336)
+	notEqual( $("#select1").find("option").length, 0, "Have some initial options" );
+	$("#select1").empty();
+	equal( $("#select1").find("option").length, 0, "No more option elements found" );
+	equal( $("#select1")[0].options.length, 0, "options.length cleared as well" );
+	});
 
 test( "jQuery.cleanData", function() {