New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects: finish() should call progress(1) #2283

Closed
mr21 opened this Issue May 9, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mr21
Contributor

mr21 commented May 9, 2015

Hi :)

On this jsfiddle.net/Mr21/cr5391w2 we can see the difference between .stop and .finish. The darkest blue block is modified only with the progress callback.
But the callback progress is not called a last time with the value 1 when we force the end of the animation.

If you are agree on this problem, I found where we should put a line to fix this problem.

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin May 10, 2015

Member

Since we're using a jQuery.Deferred for the animation we would need to call the deferred's .notifyWith() method which should do the rest for us, but I agree it seems like animations should do this on .finish() or .stop(true).

Member

dmethvin commented May 10, 2015

Since we're using a jQuery.Deferred for the animation we would need to call the deferred's .notifyWith() method which should do the rest for us, but I agree it seems like animations should do this on .finish() or .stop(true).

@mr21

This comment has been minimized.

Show comment
Hide comment
@mr21

mr21 May 11, 2015

Contributor

@dmethvin okay it's done :)

Contributor

mr21 commented May 11, 2015

@dmethvin okay it's done :)

@mgol mgol added the Effects label Sep 7, 2015

@mgol mgol added this to the 3.0.0 milestone Sep 7, 2015

@mgol mgol closed this in 3dd3d13 Sep 8, 2015

mgol added a commit that referenced this issue Sep 8, 2015

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.