Update requirejs dep when available #2290

Closed
markelog opened this Issue May 9, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@markelog
Member

markelog commented May 9, 2015

Now it causes small issue with build version, but it has a danger of breaking things in the future, we should be aware of this issue and update "requirejs" accordingly

Example, from

// Support: Firefox 18+
// Can't be in strict mode, several libs including ASP.NET trace
// the stack via arguments.caller.callee and Firefox dies if
// you try to trace through "use strict" call chains. (#13335)
//"use strict";

to

// Support: Firefox 18+
// Can't be in strict mode, several libs including ASP.NET trace
// the stack via arguments.caller.callee and Firefox dies if
// you try to trace through "use strict" call chains. (#13335)
//

Fix should have been ladnded in 2.1.17 but i still see the incorrect output.

Ref requirejs/r.js#689
/cc @jrburke

@markelog markelog added the Build label May 9, 2015

@markelog markelog changed the title from Update requirejs dep when avaliable to Update requirejs dep when available May 9, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol May 9, 2015

Member

This is just a comment so it's not terribly important.

Member

mgol commented May 9, 2015

This is just a comment so it's not terribly important.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil May 11, 2015

Member

I think all we need here is a comment saying r.js will strip "use strict"; if added.

Member

timmywil commented May 11, 2015

I think all we need here is a comment saying r.js will strip "use strict"; if added.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog May 11, 2015

Member

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict"; if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would be aware of it and fix it when appropriate fix will be landed.

Member

markelog commented May 11, 2015

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict"; if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would be aware of it and fix it when appropriate fix will be landed.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil May 11, 2015

Member

I'd rather not leave issues lying around as reminders. We can cross that
bridge if/when we come to it.
On Mon, May 11, 2015 at 10:41 Oleg Gaidarenko notifications@github.com
wrote:

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict";
if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would
be aware of it and fix it when appropriate fix will be landed.


Reply to this email directly or view it on GitHub
#2290 (comment).

Member

timmywil commented May 11, 2015

I'd rather not leave issues lying around as reminders. We can cross that
bridge if/when we come to it.
On Mon, May 11, 2015 at 10:41 Oleg Gaidarenko notifications@github.com
wrote:

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict";
if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would
be aware of it and fix it when appropriate fix will be landed.


Reply to this email directly or view it on GitHub
#2290 (comment).

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil May 11, 2015

Member

Ok, I misunderstood the issue. I thought that latest requirejs would strip the "use strict". Since the action item is just to update requirejs, I'm all for that.

Member

timmywil commented May 11, 2015

Ok, I misunderstood the issue. I thought that latest requirejs would strip the "use strict". Since the action item is just to update requirejs, I'm all for that.

@markelog markelog self-assigned this May 11, 2015

@markelog markelog closed this in a644101 May 19, 2015

markelog added a commit that referenced this issue Nov 10, 2015

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.