New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect the 'slideDown' method behavior with element with height 0 #2488

Closed
bset opened this Issue Jul 21, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@bset

bset commented Jul 21, 2015

Here is an example of this issue. Steps to reproduce it:

  1. Open example using link: http://jsfiddle.net/j53j1mLq/
  2. Click on the 'Toggle' button (maybe several times)
  3. As you can see, element with height 0 become visible for a short time and it's hidden after that
    I'm waiting for no reaction method call because of element height.

Description: on every button click the 'slideDown' and the 'slideUp' methods are called for the 'box' element in rotation.

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Jul 21, 2015

Member

This stems from a rather curious height/width exception, ultimately dating all the way back to jQuery 1.0: http://jsfiddle.net/j53j1mLq/1/.

I doubt it's still relevant, and would be comfortable removing it. Any objections, @jquery/core?

Member

gibson042 commented Jul 21, 2015

This stems from a rather curious height/width exception, ultimately dating all the way back to jQuery 1.0: http://jsfiddle.net/j53j1mLq/1/.

I doubt it's still relevant, and would be comfortable removing it. Any objections, @jquery/core?

@gnarf

This comment has been minimized.

Show comment
Hide comment
@gnarf

gnarf Jul 21, 2015

Member

Seems safe to remove to me - So long as IE whatever doesn't throw problems if we try to set width/height to 0 (but I think we were guarding that somewhere else anyway recently) - Also, lol at that comment on that line back in 1.0 :)

Member

gnarf commented Jul 21, 2015

Seems safe to remove to me - So long as IE whatever doesn't throw problems if we try to set width/height to 0 (but I think we were guarding that somewhere else anyway recently) - Also, lol at that comment on that line back in 1.0 :)

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 22, 2015

Member

If it works fine in IE8 without this hack, 👍 for removing.

Member

mgol commented Jul 22, 2015

If it works fine in IE8 without this hack, 👍 for removing.

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Jul 22, 2015

Member

Great, so who can identify what the problematic behavior actually was? "IE flicker" isn't quite precise enough for me.

Member

gibson042 commented Jul 22, 2015

Great, so who can identify what the problematic behavior actually was? "IE flicker" isn't quite precise enough for me.

@gnarf

This comment has been minimized.

Show comment
Hide comment
@gnarf

gnarf Jul 23, 2015

Member

only @jeresig probably

Member

gnarf commented Jul 23, 2015

only @jeresig probably

@jeresig

This comment has been minimized.

Show comment
Hide comment
@jeresig

jeresig Jul 23, 2015

Member

Lord knows - probably for IE 5 or something. Feel free to nuke if you can't reproduce!

Member

jeresig commented Jul 23, 2015

Lord knows - probably for IE 5 or something. Feel free to nuke if you can't reproduce!

@timmywil timmywil added the Effects label Nov 17, 2015

@timmywil timmywil modified the milestones: 3.0.1, 3.0.0 Jan 15, 2016

@timmywil timmywil self-assigned this Jan 19, 2016

timmywil added a commit to timmywil/jquery that referenced this issue Jan 19, 2016

@timmywil timmywil closed this in e04e246 Jan 21, 2016

@mgol mgol removed the Has Pull Request label Mar 6, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.