Incorrect the 'slideDown' method behavior with element with height 0 #2488

Closed
bset opened this Issue Jul 21, 2015 · 6 comments

Projects

None yet

6 participants

@bset
bset commented Jul 21, 2015

Here is an example of this issue. Steps to reproduce it:

  1. Open example using link: http://jsfiddle.net/j53j1mLq/
  2. Click on the 'Toggle' button (maybe several times)
  3. As you can see, element with height 0 become visible for a short time and it's hidden after that
    I'm waiting for no reaction method call because of element height.

Description: on every button click the 'slideDown' and the 'slideUp' methods are called for the 'box' element in rotation.

@gibson042
Member

This stems from a rather curious height/width exception, ultimately dating all the way back to jQuery 1.0: http://jsfiddle.net/j53j1mLq/1/.

I doubt it's still relevant, and would be comfortable removing it. Any objections, @jquery/core?

@gnarf
Member
gnarf commented Jul 21, 2015

Seems safe to remove to me - So long as IE whatever doesn't throw problems if we try to set width/height to 0 (but I think we were guarding that somewhere else anyway recently) - Also, lol at that comment on that line back in 1.0 :)

@mgol
Member
mgol commented Jul 22, 2015

If it works fine in IE8 without this hack, 👍 for removing.

@gibson042
Member

Great, so who can identify what the problematic behavior actually was? "IE flicker" isn't quite precise enough for me.

@gnarf
Member
gnarf commented Jul 23, 2015

only @jeresig probably

@jeresig
Member
jeresig commented Jul 23, 2015

Lord knows - probably for IE 5 or something. Feel free to nuke if you can't reproduce!

@timmywil timmywil added the Effects label Nov 17, 2015
@timmywil timmywil modified the milestone: 3.0.1, 3.0.0 Jan 15, 2016
@timmywil timmywil self-assigned this Jan 19, 2016
@timmywil timmywil pushed a commit to timmywil/jquery that referenced this issue Jan 19, 2016
Timmy Willison Effects: remove width/height exception for oldIE
Fixes gh-2488
37845d7
@timmywil timmywil pushed a commit that closed this issue Jan 21, 2016
Timmy Willison Effects: remove width/height exception for oldIE
Fixes gh-2488
Close gh-2849
e04e246
@timmywil timmywil closed this in e04e246 Jan 21, 2016
@mgol mgol removed the Has Pull Request label Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment