Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose jQuery.dir & jQuery.sibling #2512

Closed
mgol opened this issue Jul 31, 2015 · 1 comment
Closed

Don't expose jQuery.dir & jQuery.sibling #2512

mgol opened this issue Jul 31, 2015 · 1 comment
Assignees
@mgol
Labels
Traversing
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Jul 31, 2015

We have a few more undocumented APIs shipped under the jQuery object; two of them are jQuery.dir & jQuery.sibling.

Is there any reason why they should be exposed & undocumented? We should minimize the number of such cases as we did with jQuery.swap (#2058), jQuery.buildFragment (#2224) & jQuery.domManip (#2225).

See also #2513.
@mgol mgol changed the title Remove jQuery.dir & jQuery.sibling Don't expose jQuery.dir & jQuery.sibling Jul 31, 2015
@mgol mgol mentioned this issue Jul 31, 2015
Closed
@mgol mgol added this to the 3.0.0 milestone Aug 3, 2015
@mgol mgol self-assigned this Aug 3, 2015
@mgol mgol removed the Needs review label Aug 3, 2015
mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015
@mgol
Traversing: Don't expose jQuery.dir & jQuery.sibling
c574a9f 
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes jquerygh-2512
@mgol mgol mentioned this issue Aug 3, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015
@mgol
Traversing: Don't expose jQuery.dir & jQuery.sibling
ae320b5 
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes jquerygh-2512
Closes jquerygh-2525
@mgol
Copy link
Member Author

mgol commented Aug 3, 2015

PR: #2525

mgol added a commit to mgol/jquery that referenced this issue Aug 6, 2015
@mgol
Traversing: Don't expose jQuery.dir & jQuery.sibling
df75ef4 
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes jquerygh-2512
Closes jquerygh-2525
@mgol mgol closed this as completed in f9ef427 Sep 8, 2015
mgol added a commit that referenced this issue Sep 8, 2015
@mgol
Traversing: Don't expose jQuery.dir & jQuery.sibling
8c851bf 
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

(cherry-picked from f9ef427)

Fixes gh-2512
Closes gh-2525
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Traversing
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
2 participants
@dmethvin @mgol