New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose jQuery.dir & jQuery.sibling #2512

Closed
mgol opened this Issue Jul 31, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Jul 31, 2015

We have a few more undocumented APIs shipped under the jQuery object; two of them are jQuery.dir & jQuery.sibling.

Is there any reason why they should be exposed & undocumented? We should minimize the number of such cases as we did with jQuery.swap (#2058), jQuery.buildFragment (#2224) & jQuery.domManip (#2225).

See also #2513.

@mgol mgol changed the title from Remove jQuery.dir & jQuery.sibling to Don't expose jQuery.dir & jQuery.sibling Jul 31, 2015

@mgol mgol added this to the 3.0.0 milestone Aug 3, 2015

@mgol mgol self-assigned this Aug 3, 2015

@mgol mgol removed the Needs review label Aug 3, 2015

mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015

Traversing: Don't expose jQuery.dir & jQuery.sibling
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes gh-2512

mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015

Traversing: Don't expose jQuery.dir & jQuery.sibling
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes gh-2512
Closes gh-2525
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Aug 3, 2015

Member

PR: #2525

Member

mgol commented Aug 3, 2015

PR: #2525

mgol added a commit to mgol/jquery that referenced this issue Aug 6, 2015

Traversing: Don't expose jQuery.dir & jQuery.sibling
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

Fixes gh-2512
Closes gh-2525

@mgol mgol closed this in f9ef427 Sep 8, 2015

mgol added a commit that referenced this issue Sep 8, 2015

Traversing: Don't expose jQuery.dir & jQuery.sibling
jQuery.dir & jQuery.sibling are undocumented internal APIs; they shouldn't
be exposed.

(cherry-picked from f9ef427)

Fixes gh-2512
Closes gh-2525

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016

@mgol mgol removed the Has Pull Request label Mar 6, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.