Simplify isPlainObject

[gibson042]

We can skip property enumeration and just look for prototype/constructor directly (cf. #2970 (comment) ).

[markelog]

3.0.1? It seems you already have a draft for the refactoring, is there any concerns for postponing?

[mgol]

We can be adding more & more small items to the milestone & never release; I think it's good to not add new things to 3.0.0 now if not necessary. We can always change the milestone down to 3.0.0 at the moment of merging.

[markelog]

Sounds more like invitation for bureaucratic discussion, since we can also do the opposite - make it a 3.0.0 and move it to 3.0.1 if necessary, if code is ready and tests are there i'm not sure why it can't be an easy fix.

In any way, i'm not suggesting to add a blocker label, but asking @gibson042 if there is any concerns with proposed code.

[mgol]

Sounds more like invitation for bureaucratic discussion, since we can also do the opposite - make it a 3.0.0 and move it to 3.0.1 if necessary

This adds the burden of having to make an actual decision of moving it to a later milestone which can delay the release. This release has already dragged on for way too long.

if code is ready and tests are there

There is no PR so it's not ready yet.

[markelog]

I think you making an issue where there isn't one, if we can land it, i think we should, i can create pr right now, this discussion feels redundant and highly unproductive

[markelog]

Discussed at the meeting, if code will be submitted before 3.0.0 release, it will land, if not, then waiting until the next one