Simplify isPlainObject #2986

Closed
gibson042 opened this Issue Mar 11, 2016 · 6 comments

Projects

None yet

4 participants

@gibson042
Member

We can skip property enumeration and just look for prototype/constructor directly (cf. #2970 (comment) ).

@gibson042 gibson042 added the Core label Mar 11, 2016
@gibson042 gibson042 added this to the 3.0.1 milestone Mar 11, 2016
@markelog
Member

3.0.1? It seems you already have a draft for the refactoring, is there any concerns for postponing?

@mgol
Member
mgol commented Mar 11, 2016

We can be adding more & more small items to the milestone & never release; I think it's good to not add new things to 3.0.0 now if not necessary. We can always change the milestone down to 3.0.0 at the moment of merging.

@markelog
Member

Sounds more like invitation for bureaucratic discussion, since we can also do the opposite - make it a 3.0.0 and move it to 3.0.1 if necessary, if code is ready and tests are there i'm not sure why it can't be an easy fix.

In any way, i'm not suggesting to add a blocker label, but asking @gibson042 if there is any concerns with proposed code.

@mgol
Member
mgol commented Mar 12, 2016

Sounds more like invitation for bureaucratic discussion, since we can also do the opposite - make it a 3.0.0 and move it to 3.0.1 if necessary

This adds the burden of having to make an actual decision of moving it to a later milestone which can delay the release. This release has already dragged on for way too long.

if code is ready and tests are there

There is no PR so it's not ready yet.

@markelog
Member

I think you making an issue where there isn't one, if we can land it, i think we should, i can create pr right now, this discussion feels redundant and highly unproductive

@markelog
Member

Discussed at the meeting, if code will be submitted before 3.0.0 release, it will land, if not, then waiting until the next one

@markelog markelog modified the milestone: 3.0.0, 3.0.1 Mar 14, 2016
@gibson042 gibson042 added a commit to gibson042/jquery that referenced this issue Mar 14, 2016
@gibson042 gibson042 Core: Simplify isPlainObject
Fixes gh-2986
6abf6bd
@gibson042 gibson042 was assigned by timmywil Mar 21, 2016
@timmywil timmywil pushed a commit that closed this issue Apr 4, 2016
@gibson042 gibson042 + Timmy Willison Core: Simplify isPlainObject
Fixes gh-2986
Close gh-2998
e0d3bfa
@timmywil timmywil closed this in e0d3bfa Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment