Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jQuery.type #3605

Closed
gibson042 opened this issue Apr 2, 2017 · 2 comments
Closed

Deprecate jQuery.type #3605

gibson042 opened this issue Apr 2, 2017 · 2 comments
Assignees
@jbedard
Labels
Blocker Core Has Pull Request
Milestone
3.3.0

Comments

@gibson042
Copy link
Member

Description

jQuery.type is insufficient to deal with the ever-increasing list of @@toStringTag values (cf. gh-3553, gh-3600). But since it is intended for internal use anyway, so we should treat it just like jQuery.isNumeric, jQuery.proxy, jQuery.now, and jQuery.camelCase by removing it from the public API.
@gibson042 gibson042 added the Core label Apr 2, 2017
@gibson042 gibson042 added this to the 3.3.0 milestone Apr 2, 2017
This was referenced Apr 2, 2017
Closed
Closed
@markelog markelog self-assigned this Apr 3, 2017
@scottgonzalez scottgonzalez mentioned this issue May 8, 2017
Closed
@ShashankaNataraj
Copy link
Contributor

PRs accepted? I'd like to contribute to this!

@timmywil
Copy link
Member

@ShashankaNataraj absolutely!

@timmywil timmywil assigned jbedard and unassigned markelog Dec 11, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard
Core: deprecate jQuery.type
ac49da8 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard
Core: deprecate jQuery.type
370aeb1 
Fixes jquerygh-3605
@jbedard jbedard mentioned this issue Dec 18, 2017
Closed
4 tasks
jbedard added a commit to jbedard/jquery that referenced this issue Dec 19, 2017
@jbedard
Core: deprecate jQuery.type
e3e1db1 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Dec 19, 2017
@jbedard
Core: deprecate jQuery.type
f46b6d7 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 5, 2018
@jbedard
Core: deprecate jQuery.type
4bb8215 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 7, 2018
@jbedard
Core: deprecate jQuery.type
8d65136 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
@jbedard
Core: deprecate jQuery.type
8219dee 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
@jbedard
Core: deprecate jQuery.type
bed23d1 
Fixes jquerygh-3605
This was referenced Jan 9, 2018
Closed
Closed
jbedard added a commit to jbedard/jquery that referenced this issue Jan 14, 2018
@jbedard
Core: deprecate jQuery.type
6594689 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
@jbedard
Core: deprecate jQuery.type
8efb2a8 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
@jbedard
Core: deprecate jQuery.type
da7f97d 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
@jbedard
Core: deprecate jQuery.type
ce36ff8 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
@jbedard
Core: deprecate jQuery.type
de0b60c 
Fixes jquerygh-3605
jbedard added a commit to jbedard/jquery that referenced this issue Jan 16, 2018
@jbedard
Core: deprecate jQuery.type
b6691b6 
Fixes jquerygh-3605
@mgol mgol mentioned this issue Mar 28, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbedard jbedard

Labels
Blocker Core Has Pull Request
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Core: deprecate jQuery.type jbedard/jquery
5 participants
@jbedard @timmywil @ShashankaNataraj @markelog @gibson042