Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.type #3605

Closed
gibson042 opened this issue Apr 2, 2017 · 2 comments
Closed

Deprecate jQuery.type #3605

gibson042 opened this issue Apr 2, 2017 · 2 comments
Assignees
Milestone

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Apr 2, 2017

Description

jQuery.type is insufficient to deal with the ever-increasing list of @@toStringTag values (cf. gh-3553, gh-3600). But since it is intended for internal use anyway, so we should treat it just like jQuery.isNumeric, jQuery.proxy, jQuery.now, and jQuery.camelCase by removing it from the public API.

@ShashankaNataraj
Copy link
Contributor

@ShashankaNataraj ShashankaNataraj commented Jun 27, 2017

PRs accepted? I'd like to contribute to this!

@timmywil
Copy link
Member

@timmywil timmywil commented Jun 27, 2017

@ShashankaNataraj absolutely!

@timmywil timmywil assigned jbedard and unassigned markelog Dec 11, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard jbedard mentioned this issue Dec 18, 2017
4 of 4 tasks complete
jbedard added a commit to jbedard/jquery that referenced this issue Dec 19, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 19, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Jan 5, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 7, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 14, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 15, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 16, 2018
@timmywil timmywil closed this in 1ea092a Jan 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.