Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jQuery.isFunction #3609

Closed
gibson042 opened this issue Apr 2, 2017 · 5 comments · Fixed by #3893
Closed

Deprecate jQuery.isFunction #3609

gibson042 opened this issue Apr 2, 2017 · 5 comments · Fixed by #3893
Assignees
@jbedard
Labels
Blocker Core Has Pull Request
Milestone
3.3.0

Comments

@gibson042
Copy link
Member

Description

Everything must go! #3600 (comment)
@markelog markelog added the Core label Apr 3, 2017
@akihikodaki
Copy link

How could the internal implementation of jQuery (jQuery.Deferred, which I'm concerning, for example) be after deprecating jQuery.isFunction?

@mgol
Copy link
Member

mgol commented Apr 3, 2017

@akihikodaki We can move it to an internal AMD module and still use it but it would no longer be a public API after the deprecation period ends.

@akihikodaki
Copy link

@mgol That does not solve #3596. jQuery.Deferred could not recognize some functions because of jQuery.isFunction. I think @gibson042 is intended to solve also the problem by this deprecation.

@gibson042
Copy link
Member Author

I expected #3601 to fix the issue underlying your Deferred problem, it just needs an adjustment. This is a separate issue, intended to put jQuery.isFunction on the path towards becoming a purely internal API.

@timmywil timmywil added this to the 3.3.0 milestone Apr 3, 2017
@akihikodaki akihikodaki mentioned this issue Apr 4, 2017
Closed
@akihikodaki
Copy link

This is a separate issue, intended to put jQuery.isFunction on the path towards becoming a purely internal API.

Opened #3601 for the problem causing the Deferred flaw.

@yumetodo yumetodo mentioned this issue Apr 4, 2017
Closed
3 tasks
@timmywil timmywil assigned jbedard and unassigned markelog Dec 11, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard
Core: deprecate jQuery.isFunction
6ac5184 
Fixes jquerygh-3609
@jbedard jbedard mentioned this issue Dec 18, 2017
Merged
4 tasks
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard
Core: deprecate jQuery.isFunction
74b0e44 
Fixes jquerygh-3609
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard
Core: deprecate jQuery.isFunction
9729982 
Fixes jquerygh-3609
@timmywil timmywil mentioned this issue Jan 3, 2018
Closed
jbedard added a commit to jbedard/jquery that referenced this issue Jan 5, 2018
@jbedard
Core: deprecate jQuery.isFunction
c40d707 
Fixes jquerygh-3609
@jbedard jbedard mentioned this issue Jan 5, 2018
Closed
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
@jbedard
Core: deprecate jQuery.isFunction
4657561 
Fixes jquerygh-3609
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
@jbedard
Core: deprecate jQuery.isFunction
33ea9fd 
Fixes jquerygh-3609
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
@jbedard
Core: deprecate jQuery.isFunction
32e3301 
Fixes jquerygh-3609
jbedard added a commit that referenced this issue Jan 15, 2018
@jbedard
Core: deprecate jQuery.isFunction
3d732cc 
Fixes gh-3609
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbedard jbedard

Labels
Blocker Core Has Pull Request
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Core: deprecate jQuery.isFunction jbedard/jquery
6 participants
@jbedard @timmywil @markelog @gibson042 @mgol @akihikodaki