Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.isFunction #3609

Closed
gibson042 opened this issue Apr 2, 2017 · 5 comments
Closed

Deprecate jQuery.isFunction #3609

gibson042 opened this issue Apr 2, 2017 · 5 comments
Assignees
Milestone

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Apr 2, 2017

Description

Everything must go! #3600 (comment)

@markelog markelog added the Core label Apr 3, 2017
@akihikodaki
Copy link

@akihikodaki akihikodaki commented Apr 3, 2017

How could the internal implementation of jQuery (jQuery.Deferred, which I'm concerning, for example) be after deprecating jQuery.isFunction?

@mgol
Copy link
Member

@mgol mgol commented Apr 3, 2017

@akihikodaki We can move it to an internal AMD module and still use it but it would no longer be a public API after the deprecation period ends.

@akihikodaki
Copy link

@akihikodaki akihikodaki commented Apr 3, 2017

@mgol That does not solve #3596. jQuery.Deferred could not recognize some functions because of jQuery.isFunction. I think @gibson042 is intended to solve also the problem by this deprecation.

@gibson042
Copy link
Member Author

@gibson042 gibson042 commented Apr 3, 2017

I expected #3601 to fix the issue underlying your Deferred problem, it just needs an adjustment. This is a separate issue, intended to put jQuery.isFunction on the path towards becoming a purely internal API.

@akihikodaki
Copy link

@akihikodaki akihikodaki commented Apr 4, 2017

This is a separate issue, intended to put jQuery.isFunction on the path towards becoming a purely internal API.

Opened #3601 for the problem causing the Deferred flaw.

@timmywil timmywil added the Blocker label Jun 19, 2017
@timmywil timmywil assigned jbedard and unassigned markelog Dec 11, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
@jbedard jbedard mentioned this issue Dec 18, 2017
4 of 4 tasks complete
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Dec 18, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Jan 5, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jan 8, 2018
jbedard added a commit that referenced this issue Jan 15, 2018
Fixes gh-3609
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.